Maniphest T195633

Enable the internationalised names to be available to Graph:Street map with marks
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RobinLeicester
	May 25 2018, 9:54 PM

Description

The 2018 improvements to internationalised names are a vast improvement for maplink and mapframe. It would be great (and maybe not complicated) to make them available to the other mapping template at 'Graph:Street map with marks' as well
To have the new default of 'language of the wiki', even without all the additional versions, would be a huge improvement over the current version for pretty much everyone. For consistent terminology the current 'osm-intl' could be renamed as osm-local to match the maplink usage, leaving osm-intl as the new default. The no-labels 'osm' style has also been useful, so to end up with all three would be great.
The hint I have received is that it needs to add a language parameter to the graphoid service, and let it pass it through to the map service, at https://github.com/nyurik/mw-graph-shared/blob/master/src/VegaWrapper.js#L306

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Graph	master	+10 -2	Bump url parsing dep to enable lang param
	mediawiki/services/graphoid	master	+2 -2	Bump url parsing dep to enable lang param

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		TheDJ	T195633 Enable the internationalised names to be available to Graph:Street map with marks
		Declined		None	T196001 Graphoid service git master is in a broken, untestable state

Event Timeline

RobinLeicester created this task.May 25 2018, 9:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2018, 9:54 PM

Thx for filing, the fix is really trivial - just add a few js lines to the code linked above, and deploy the newer version of graphoid and mediawiki.

Yurik added a project: good first task.May 28 2018, 7:08 PM

Change 436306 had a related patch set uploaded (by Yurik; owner: Yurik):
[mediawiki/extensions/Graph@master] Bump url parsing dep to enable lang param

https://gerrit.wikimedia.org/r/436306

gerritbot added a project: Patch-For-Review.May 30 2018, 3:16 PM

Change 436326 had a related patch set uploaded (by Yurik; owner: Yurik):
[mediawiki/services/graphoid@master] Bump url parsing dep to enable lang param

https://gerrit.wikimedia.org/r/436326

This task is blocked on T196001 -- once graphoid service is back to testable state, simply +2 and deploy https://gerrit.wikimedia.org/r/#/c/436326/

• Vvjjkkii renamed this task from Enable the internationalised names to be available to Graph:Street map with marks to 28baaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from 28baaaaaaa to Enable the internationalised names to be available to Graph:Street map with marks.Jul 2 2018, 3:44 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)