Page MenuHomePhabricator
Create Task
Maniphest T195645

Wrong operator in MinervaNeue skin test
Closed, ResolvedPublic
Actions

Description

Current Version
MinervaNeue: master(57a959c483)

Situation
While I run phpunit test, show some Warning messages:

PHP Warning:  A non-numeric value encountered in /mediawiki/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 335

PHP Warning:  A non-numeric value encountered in /mediawiki/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 335

PHP Warning:  A non-numeric value encountered in /mediawiki/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 336

PHP Warning:  A non-numeric value encountered in /mediawiki/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 351

PHP Warning:  A non-numeric value encountered in /mediawiki/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 351

PHP Warning:  A non-numeric value encountered in /mediawiki/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 352

PHP Warning:  A non-numeric value encountered in /mediawiki/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 367

PHP Warning:  A non-numeric value encountered in /mediawiki/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 367

PHP Warning:  A non-numeric value encountered in /mediawiki/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 368

PHP Warning:  A non-numeric value encountered in /mediawiki/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 383

PHP Warning:  A non-numeric value encountered in /mediawiki/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 383

PHP Warning:  A non-numeric value encountered in /mediawiki/w/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 384

PHP Warning:  A non-numeric value encountered in /mediawiki/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 399

PHP Warning:  A non-numeric value encountered in /mediawiki/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php on line 399

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use . operator instead of + operatormediawiki/skins/MinervaNeueREL1_31+9 -9
Use . operator instead of + operatormediawiki/skins/MinervaNeuemaster+9 -9
Customize query in gerrit

Related Objects

Event Timeline

RazeSoldier created this task.May 26 2018, 8:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2018, 8:32 AM
gerritbot subscribed.May 26 2018, 8:39 AM

Change 435616 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/skins/MinervaNeue@master] Use . operator instead of + operator

https://gerrit.wikimedia.org/r/435616

gerritbot added a project: Patch-For-Review.May 26 2018, 8:39 AM
RazeSoldier moved this task from Backlog to Bugs on the MinervaNeue board.May 26 2018, 8:41 AM
RazeSoldier triaged this task as Low priority.May 26 2018, 8:44 AM
Reedy mentioned this in T195683: Warn if using + to concat strings.May 26 2018, 9:16 PM
gerritbot added a comment.May 26 2018, 9:25 PM

Change 435616 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Use . operator instead of + operator

https://gerrit.wikimedia.org/r/435616

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 26 2018, 10:00 PM
Krinkle closed this task as Resolved.May 26 2018, 10:21 PM
gerritbot added a comment.May 27 2018, 5:04 AM

Change 435679 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/skins/MinervaNeue@REL1_31] Use . operator instead of + operator

https://gerrit.wikimedia.org/r/435679

gerritbot added a comment.May 27 2018, 6:12 AM

Change 435679 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@REL1_31] Use . operator instead of + operator

https://gerrit.wikimedia.org/r/435679

RazeSoldier removed a project: Patch-For-Review.May 27 2018, 6:34 AM
• Vvjjkkii renamed this task from Wrong operator in MinervaNeue skin test to q8baaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed RazeSoldier as the assignee of this task.
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from q8baaaaaaa to Wrong operator in MinervaNeue skin test.Jul 2 2018, 1:14 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to RazeSoldier.
CommunityTechBot lowered the priority of this task from High to Low.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits