Page MenuHomePhabricator
Create Task
Maniphest T195692

Attempt to undelete page causes error: Fatal exception of type IncompleteRevisionException: user_text field must not be ''!
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

I was attempting to undelete the page "List of people by name: Johns" on enwiki to make it easier to import an old edit into its history from the Nostalgia Wikipedia. I received this error as a result:
[WwoLcQpAMFIAAD@ZR1YAAAAC] 2018-05-27 01:35:46: Fatal exception of type "MediaWiki\Storage\IncompleteRevisionException"

I found a way around this without having to undelete any of the edits, and the page doesn't need to be restored. However, I'm reporting this problem in case it points to a deeper issue.

exception.class	       	MediaWiki\Storage\IncompleteRevisionException
exception.file	       	/srv/mediawiki/php-1.32.0-wmf.4/includes/Storage/RevisionStore.php:310
exception.message	user_text field must not be ''!
exception.trace
#0 /srv/mediawiki/php-1.32.0-wmf.4/includes/Storage/RevisionStore.php(402): MediaWiki\Storage\RevisionStore->failOnEmpty(string, string)
#1 /srv/mediawiki/php-1.32.0-wmf.4/includes/Revision.php(1091): MediaWiki\Storage\RevisionStore->insertRevisionOn(MediaWiki\Storage\RevisionArchiveRecord, Wikimedia\Rdbms\DatabaseMysqli)
#2 /srv/mediawiki/php-1.32.0-wmf.4/includes/page/PageArchive.php(678): Revision->insertOn(Wikimedia\Rdbms\DatabaseMysqli)
#3 /srv/mediawiki/php-1.32.0-wmf.4/includes/page/PageArchive.php(419): PageArchive->undeleteRevisions(array, boolean, string)
#4 /srv/mediawiki/php-1.32.0-wmf.4/includes/specials/SpecialUndelete.php(1147): PageArchive->undelete(array, string, array, boolean, User)
#5 /srv/mediawiki/php-1.32.0-wmf.4/includes/specials/SpecialUndelete.php(201): SpecialUndelete->undelete()
#6 /srv/mediawiki/php-1.32.0-wmf.4/includes/specialpage/SpecialPage.php(522): SpecialUndelete->execute(NULL)
#7 /srv/mediawiki/php-1.32.0-wmf.4/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(861): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(524): MediaWiki->main()
#11 /srv/mediawiki/php-1.32.0-wmf.4/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}
exception_id	       	WwoLcQpAMFIAAD@ZR1YAAAAC
exception_url	       	/w/index.php?title=Special:Undelete&action=submit

Details

SubjectRepoBranchLines +/-
Use "Unknown user" instead of an empty user name.mediawiki/coremaster+81 -5
Customize query in gerrit

Related Objects

Event Timeline

Graham87 created this task.May 27 2018, 1:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2018, 1:39 AM
Legoktm added projects: MediaWiki-General, Wikimedia-production-error.May 27 2018, 1:42 AM
Legoktm added subscribers: daniel, Addshore.
Aklapper edited projects, added MediaWiki-Revision-deletion; removed MediaWiki-General.May 27 2018, 9:07 PM
Aklapper updated the task description. (Show Details)

Thanks for reporting this!
Error might surface "now" because of https://phabricator.wikimedia.org/rMW7eb7f04771a7c246ec67b15b445ba588daa4c92c .
I added the corresponding stacktrace. Might be MCR territory but leaving that to the developers.

Aklapper renamed this task from Attempt to undelete page causes error: Fatal exception of type "MediaWiki\Storage\IncompleteRevisionException to Attempt to undelete page causes error: Fatal exception of type IncompleteRevisionException: user_text field must not be ''!.May 27 2018, 9:09 PM
Ciencia_Al_Poder subscribed.May 27 2018, 9:30 PM

I'd say T167246: Refactor "user" & "user_text" fields into "actor" reference table

daniel added a subscriber: Anomie.May 27 2018, 10:00 PM
daniel added a comment.May 27 2018, 10:05 PM

This would happen if there was a row in the archive table with ar_user_text = ''. The question is then - why is it there, can it be fixed, and how do we handle this siutation more gracefully. The system expects every revision to have a "actor". What do we do if that information was somehow lost?

Anomie added a comment.May 28 2018, 6:08 PM
In T195692#4235168, @Ciencia_Al_Poder wrote:

I'd say T167246: Refactor "user" & "user_text" fields into "actor" reference table

You'd say wrong. Patches for T174025: Implement MCR revision retrieval legacy version are the cause. The actor table stuff doesn't care if the name is empty.

In T195692#4235247, @daniel wrote:

This would happen if there was a row in the archive table with ar_user_text = ''. The question is then - why is it there, can it be fixed, and how do we handle this siutation more gracefully. The system expects every revision to have a "actor". What do we do if that information was somehow lost?

Sigh. There are indeed such rows, on multiple wikis. There are also rows in revision with rev_user_text = ''. No idea why, best guess is "old bugs". Or possibly someone screwing up the XML file when doing imports, based on the revisions with relatively recent timestamps that I checked all seeming to be on imported revisions.

Probably the most straightforward thing to do is to use the user_id (or actor_id) to get the name if one is set (which is hopefully already happening), and otherwise set it to "Unknown user".

daniel added a comment.EditedMay 28 2018, 7:07 PM

Probably the most straightforward thing to do is to use the user_id (or actor_id) to get the name if one is set (which is hopefully already happening), and otherwise set it to "Unknown user".

This does happen, via User::newFromAnyId(). I'm having a hard time actually reproducing this. With user=0 and user_text='', I get InvalidArgumentException( 'Cannot create a user with no name, no ID, and no actor ID' ) from User::newFromAnyId. With a valid ID, the correct user is loaded and the name is used. With a bad ID, the name is set to "127.0.0.1" by virtue of User::loadDefaults() being called from User::loadFromDatabase() when failing to find a database row.

EDIT: found it. RevisionStore catches the InvalidArgumentException, logs a warning, and then does new UserIdentityValue( 0, '', 0 );

Anyway. We still need to be able to restore revisions that have user=0 and user_text=''. Setting it to "Unknown user" doesn't seem safe, since it is possible to actually create a user with that name, no? Maybe it could be set to "<unknown>" or something like that?

daniel added a project: Multi-Content-Revisions.May 28 2018, 7:20 PM
gerritbot subscribed.May 28 2018, 7:20 PM

Change 435822 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Use "<unknown>" as the user name when ar_user_text is empty.

https://gerrit.wikimedia.org/r/435822

gerritbot added a project: Patch-For-Review.May 28 2018, 7:20 PM
Anomie added a comment.May 28 2018, 11:06 PM
In T195692#4237230, @daniel wrote:

Setting it to "Unknown user" doesn't seem safe, since it is possible to actually create a user with that name, no?

No. https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/e81ee7d18de0f2f90a8ed50bb691201eb650ba75/includes/DefaultSettings.php#4823

daniel added a comment.May 29 2018, 9:28 AM

@Anomie oh, I didn't know that, thanks! amended.

• Vvjjkkii renamed this task from Attempt to undelete page causes error: Fatal exception of type IncompleteRevisionException: user_text field must not be ''! to f7baaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from f7baaaaaaa to Attempt to undelete page causes error: Fatal exception of type IncompleteRevisionException: user_text field must not be ''!.Jul 2 2018, 3:40 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Krinkle triaged this task as High priority.Jul 11 2018, 2:12 AM
Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.
Krinkle subscribed.

Given this would cause a valid user action to fail without recovery or workaround, raising priority.

daniel added a comment.Jul 11 2018, 2:01 PM

I just rebased the patch, should be ready to be merged

Ciencia_Al_Poder mentioned this in T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !.Jul 30 2018, 9:29 AM
Krinkle added a project: Core-Platform-Team-Old.Jul 31 2018, 10:56 PM
CCicalese_WMF moved this task from Inbox to CPT-Q1-Jul-Sep-2018 on the Core-Platform-Team-Old board.Aug 7 2018, 12:25 AM
CCicalese_WMF edited projects, added Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018); removed Core-Platform-Team-Old.
CCicalese_WMF moved this task from Backlog to In Progress on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.
daniel moved this task from Inbox to Next on the Multi-Content-Revisions board.Sep 17 2018, 1:07 PM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 18 2018, 4:10 PM
gerritbot added a comment.Sep 18 2018, 6:12 PM

Change 435822 merged by jenkins-bot:
[mediawiki/core@master] Use "Unknown user" instead of an empty user name.

https://gerrit.wikimedia.org/r/435822

Jdforrester-WMF moved this task from Next to Done on the Multi-Content-Revisions board.Sep 18 2018, 6:20 PM
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed Patch-For-Review.
CCicalese_WMF moved this task from Done to Watching on the Multi-Content-Revisions board.Sep 18 2018, 10:08 PM
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 1:10 AM
Tgr subscribed.Sep 24 2018, 10:16 PM

Closing as the error is fixed. The followup is in T205353: Clean up empty ar_user_text and rev_user_text fields.

Tgr closed this task as Resolved.Sep 24 2018, 10:16 PM
Tgr claimed this task.
Tgr reassigned this task from Tgr to daniel.
CCicalese_WMF moved this task from In Progress to Closed on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Oct 1 2018, 12:40 PM
CCicalese_WMF moved this task from Watching to Done on the Multi-Content-Revisions board.Oct 1 2018, 12:58 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Piastu subscribed.Oct 27 2019, 4:38 PM
Piastu unsubscribed.
Piastu subscribed.
Wargo mentioned this in T236624: Unable to restore page: IncompleteRevisionException for some revisions.Oct 27 2019, 4:51 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL