Page MenuHomePhabricator
Create Task
Maniphest T195707

Table column/row dialogs too narrow in some translations
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
Cirdan
May 27 2018, 5:35 PM
Tags
Referenced Files
F24014772: grafik.png
Jul 23 2018, 4:59 PM
F24014758: grafik.png
Jul 23 2018, 4:59 PM
F24014768: grafik.png
Jul 23 2018, 4:59 PM
F18565460: grafik.png
May 27 2018, 5:35 PM
F18565454: grafik.png
May 27 2018, 5:35 PM
Subscribers
Aklapper
Cirdan
gerritbot

Description

As reported and visualized here, the column/row dialog is too narrow for the description at least in the current German and Dutch translations:

grafik.png (464×506 px, 15 KB)
grafik.png (464×401 px, 14 KB)

While this can be fixed through shortening the text, it would be preferable for the width to grow with the text to avoid the problem for all time, e.g. when the font face/size/weight changes in the future.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (bbe825690)mediawiki/extensions/VisualEditormaster+2 -1
ve.ui.TableLineContext: Use automatic widthVisualEditor/VisualEditormaster+6 -5
PopupWidget: Allow automatic width (not hardcoded)oojs/uimaster+8 -9
Customize query in gerrit

Related Objects

Event Timeline

Cirdan created this task.May 27 2018, 5:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2018, 5:35 PM
Aklapper added a project: VisualEditor-Tables.May 28 2018, 6:29 AM
gerritbot subscribed.May 28 2018, 8:57 PM

Change 435931 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] PopupWidget: Allow automatic width (not hardcoded)

https://gerrit.wikimedia.org/r/435931

gerritbot added a project: Patch-For-Review.May 28 2018, 8:57 PM

Change 435932 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.TableLineContext: Use automatic width

https://gerrit.wikimedia.org/r/435932

matmarex claimed this task.May 28 2018, 8:58 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.
gerritbot added a comment.May 29 2018, 1:12 PM

Change 435783 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] VWIP Table context to dropdown

https://gerrit.wikimedia.org/r/435783

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.May 29 2018, 1:42 PM
gerritbot added a comment.Jun 20 2018, 6:28 PM

Change 435931 merged by jenkins-bot:
[oojs/ui@master] PopupWidget: Allow automatic width (not hardcoded)

https://gerrit.wikimedia.org/r/435931

• Deskana triaged this task as Medium priority.Jun 27 2018, 2:33 PM
• Deskana edited projects, added VisualEditor; removed VisualEditor (Current work).
• Vvjjkkii renamed this task from Table column/row dialogs too narrow in some translations to 06baaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii removed matmarex as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: matmarex; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from 06baaaaaaa to Table column/row dialogs too narrow in some translations.Jul 2 2018, 3:38 PM
CommunityTechBot assigned this task to matmarex.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: matmarex.
gerritbot added a comment.Jul 5 2018, 5:51 PM

Change 435932 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.TableLineContext: Use automatic width

https://gerrit.wikimedia.org/r/435932

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jul 5 2018, 6:12 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Jul 5 2018, 11:10 PM

Change 444139 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbe825690)

https://gerrit.wikimedia.org/r/444139

gerritbot added a comment.Jul 6 2018, 6:13 PM

Change 444139 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbe825690)

https://gerrit.wikimedia.org/r/444139

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed Patch-For-Review.Jul 6 2018, 6:17 PM
Cirdan closed this task as Resolved.Jul 23 2018, 4:59 PM

All text is visible now:

grafik.png (212×235 px, 4 KB)

grafik.png (214×263 px, 4 KB)

grafik.png (202×225 px, 4 KB)

• Deskana moved this task from QA to Product owner review on the VisualEditor (Current work) board.Jul 31 2018, 2:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL