Maniphest T195764

Template diff should consider empty string as unset
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	May 28 2018, 12:24 PM

Description

https://en.wikipedia.org/w/index.php?title=Land_Public_Transport_Commission_(Malaysia)&curid=27606516&diff=843329178&oldid=843329101&diffmode=visual

Gives this message, which isn't very logical:

superseding changed from to ''Absorbed into [[Ministry of Transport (Malaysia)|Ministry of Transport]]''

Details

	Subject	Repo	Branch	Lines +/-
	Fix template param diff when value is empty string	mediawiki/extensions/VisualEditor	master	+6 -3

Customize query in gerrit

Related Objects

Mentioned In: T188389: Visual diff: Provide a more detailed description of template changes

Event Timeline

Esanders created this task.May 28 2018, 12:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2018, 12:24 PM

Esanders updated the task description. (Show Details)May 28 2018, 1:56 PM

Esanders set the point value for this task to 1.

Change 435787 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix template param diff when value is empty string

https://gerrit.wikimedia.org/r/435787

gerritbot added a project: Patch-For-Review.May 28 2018, 2:00 PM

After:

Esanders moved this task from To Triage to Current work on the VisualEditor board.May 28 2018, 2:23 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 435787 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix template param diff when value is empty string

https://gerrit.wikimedia.org/r/435787

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 28 2018, 7:00 PM

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.May 30 2018, 4:45 PM

• Deskana closed this task as Resolved.May 31 2018, 9:51 AM

• Deskana claimed this task.

• Deskana triaged this task as Medium priority.

matmarex mentioned this in T188389: Visual diff: Provide a more detailed description of template changes.Jun 14 2018, 6:59 PM

• Vvjjkkii renamed this task from Template diff should consider empty string as unset to f5baaaaaaa.Jul 1 2018, 1:07 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed • Deskana as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii edited subscribers, added: • Deskana; removed: gerritbot, Aklapper.

CommunityTechBot renamed this task from f5baaaaaaa to Template diff should consider empty string as unset.Jul 2 2018, 3:30 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to • Deskana.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot set the point value for this task to 1.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: • Deskana.

Template diff should consider empty string as unsetClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Template diff should consider empty string as unset
Closed, ResolvedPublic1 Estimated Story Points
Actions