| Pginer-WMF | |
| May 28 2018, 1:09 PM |
| F22692270: Screen Shot 2018-06-26 at 12.53.49 PM.png | |
| Jun 26 2018, 9:04 PM |
| F18578955: Screen Shot 2018-05-28 at 14.59.42.png | |
| May 28 2018, 1:09 PM |
On some articles, the first paragraph seems not to be correctly processed for some reason. In the example, the article "Paris" shows red links in the first paragraph of the source text. These links exist in the original article, and they should be shown as regular links (in blue) instead.
I found the issue when translating "Paris" from English to Catalan:
I extracted a minimal html snippet that can cause the issue
<body id="mwAA" lang="en" class="mw-content-ltr sitedir-ltr ltr mw-body-content parsoid-body mediawiki mw-parser-output"
dir="ltr">
<section data-mw-section-id="0" id="mwAQ">
<p id="mwEA">
<b id="mwEQ">Paris</b> >is the
<a rel="mw:WikiLink" href="./Capital_city" title="Capital city" id="mwFA">capital</a> most populous city of
<a rel="mw:WikiLink" href="./France" title="France" id="mwFg">France</a>, with an area of
<span about="#mwt16" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"convert","href":"./Template:Convert"},"params":{"1":{"wt":"105"},"2":{"wt":"km2"},"abbr":{"wt":"off"}},"i":0}}]}'
id="mwFw">105 square kilometres (41 square miles)</span>
and a population of 2,206,488.
</p>
</section>
</body>When this is segmented and returned from cxserver gives the output:
<body class="mw-content-ltr sitedir-ltr ltr mw-body-content parsoid-body mediawiki mw-parser-output" dir="ltr" id="mwAA"
lang="en">
<section id="cxSourceSection0" rel="cx:Section">
<p id="mwEA">
<b id="mwEQ">Paris</b> is the
<a href="./Capital_city" id="mwFA" rel="mw:WikiLink" title="Capital city">capital</a> and
<a href="./List_of_communes_in_France_with_over_20,000_inhabitants" id="mwFQ" rel="mw:WikiLink" title="List of communes in France with over 20,000 inhabitants">most populous city</a> of
<a href="./France" id="mwFg" rel="mw:WikiLink" title="France">France</a>, with an area of
<span about="#mwt16" data-mw="{"parts":[{"template":{"target":{"wt":"convert","href":"./Template:Convert"},"params":{"1":{"wt":"105"},"2":{"wt":"km2"},"abbr":{"wt":"off"}},"i":0}}]}"
id="mwFw" typeof="mw:Transclusion">105 square kilometres (41 square miles)</span> and a population of 2,206,488. </p>
</section>
</body>Note that the segmentation did not happen, the links did not get link-id attribute or cx-link class.
If we remove that convert template, we get correct output
<body class="mw-content-ltr sitedir-ltr ltr mw-body-content parsoid-body mediawiki mw-parser-output" dir="ltr" id="mwAA"
lang="en">
<section id="cxSourceSection0" rel="cx:Section">
<p id="mwEA">
<span class="cx-segment" data-segmentid="0">
<b id="mwEQ">Paris</b> >is the
<a class="cx-link" data-linkid="1" href="./Capital_city" id="mwFA" rel="mw:WikiLink" title="Capital city">capital</a> most populous city of
<a class="cx-link" data-linkid="2" href="./France" id="mwFg" rel="mw:WikiLink"
title="France">France</a>, with an area of and a population of 2,206,488. </span>
</p>
</section>
</body>Since links does not have cx-link class, VE consider it as usual VE mw link and linkcache customization does not work
I identified 3 bugs to fix.
Change 437728 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Decouple segmentation and setting link ids
Change 437742 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Do not miss to segment if the textblock has inline non-segmentable
Change 437728 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Decouple segmentation and setting link ids
Change 437742 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Do not miss to segment if the textblock has inline non-segmentable
Checked in cx2-testing - the majority of links are displayed ok:
There are still some cases when red links unreasonably appear in source articles: