Maniphest T195802

Source editing icons offset with MSUpload in REL1_31
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dan.mulholland
	May 28 2018, 10:59 PM

Description

With MsUpload enabled and editing the wikitext source, the following buttons (some in both rows) are offset too low incorrectly

Link
Image Gallery
Redirect
Reference
Table

Without MsUpload;

With MsUpload:

I suspect these are caused by the way the additional icons are added by MsUpload.

I am testing using the REL1_31 branch (rc0)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix toolbar alignment for MediaWiki version 1.31	mediawiki/extensions/MsUpload	REL1_31	+4 -1
	Fix toolbar alignment for MediaWiki version 1.31	mediawiki/extensions/MsUpload	master	+4 -1

Customize query in gerrit

Event Timeline

Dan.mulholland created this task.May 28 2018, 10:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2018, 10:59 PM

Dan.mulholland updated the task description. (Show Details)May 28 2018, 11:00 PM

Reedy added a project: MediaWiki-extensions-Other.May 29 2018, 12:02 AM

Aklapper edited projects, added MediaWiki-extensions-MsUpload; removed MediaWiki-extensions-Other.May 29 2018, 8:06 AM

• Vvjjkkii renamed this task from Source editing icons offset with MSUpload in REL1_31 to d4baaaaaaa.Jul 1 2018, 1:07 AM

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from d4baaaaaaa to Source editing icons offset with MSUpload in REL1_31.Jul 2 2018, 3:14 AM

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot added a subscriber: Aklapper.

A "not great but good enough" solution is to change the alignment of the other icons in MediaWiki:Common.css

.oo-ui-buttonElement {
	vertical-align: top;
}

yielding:

tosfos claimed this task.Jul 13 2018, 6:54 PM

Change 445655 had a related patch set uploaded (by tosfos; owner: tosfos):
[mediawiki/extensions/MsUpload@master] Fix toolbar alignment for MediaWiki version 1.31

https://gerrit.wikimedia.org/r/445655

gerritbot added a project: Patch-For-Review.Jul 13 2018, 6:56 PM

Change 445655 merged by jenkins-bot:
[mediawiki/extensions/MsUpload@master] Fix toolbar alignment for MediaWiki version 1.31

https://gerrit.wikimedia.org/r/445655

Tested the patch and the issue seems fixed. Thanks @Samwilson !

Yes, great job @Dan.mulholland. Thank you also from my side!

Change 460696 had a related patch set uploaded (by Samwilson; owner: tosfos):
[mediawiki/extensions/MsUpload@REL1_31] Fix toolbar alignment for MediaWiki version 1.31

https://gerrit.wikimedia.org/r/460696

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 15 2018, 9:30 AM

Change 460696 merged by jenkins-bot:
[mediawiki/extensions/MsUpload@REL1_31] Fix toolbar alignment for MediaWiki version 1.31

https://gerrit.wikimedia.org/r/460696

Aklapper removed a subscriber: MediaWiki-extensions-MsUpload.May 16 2023, 11:42 AM

Maintenance_bot removed a project: Patch-For-Review.May 16 2023, 12:13 PM

	F23324252: image.png
	Jul 4 2018, 8:31 PM

Source editing icons offset with MSUpload in REL1_31Closed, ResolvedPublicActions

Description

Details

Event Timeline

Source editing icons offset with MSUpload in REL1_31
Closed, ResolvedPublic
Actions