Page MenuHomePhabricator
Create Task
Maniphest T195840

Track when a CentralNotice banner was displayed to the user in NavTiming
Closed, ResolvedPublic
Actions

Description

I don't think we record that information right now and it can effect performance perception quite a bit to have the late-loading banner.

Ideally we wouldn't just track that the user was targeted by a banner, but also the time when it was displayed to the user.

This will be particularly useful in the context of T187299: User-perceived page load performance study where we will be able to verify if the late appearance of a banner pushing down content negatively affects user sentiment about performance.

Details

SubjectRepoBranchLines +/-
Record mwCentralNoticeBanner in CentralNoticeTimingmediawiki/extensions/NavigationTimingmaster+116 -12
Add performance mark for when banner is insertedmediawiki/extensions/CentralNoticewmf_deploy+4 -0
Add performance mark for when banner is insertedmediawiki/extensions/CentralNoticewmf_deploy+4 -0
Add performance mark for when banner is insertedmediawiki/extensions/CentralNoticemaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Gilles created this task.May 29 2018, 1:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2018, 1:24 PM
AndyRussG subscribed.May 29 2018, 1:37 PM
• Imarlier moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.May 29 2018, 8:44 PM
• Gilles moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.May 29 2018, 8:44 PM
Krinkle subscribed.May 29 2018, 9:05 PM

The extra data point ("a CentralNotice banner was shown") could be one of various data points to collect to help guess a probable cause for the (perceived) slower load time. This relates to T181956 which also intends to collect extra data for higher load times.

We may want to consider creating a separate beacon for this and other data that we'd fire from the study and/or from the oversampling case. E.g. something like "PageLoadBreakdown" or some such. There may also be something salvageable from T186295.

AndyRussG added a comment.May 30 2018, 12:11 AM

For CentralNotice, it should be pretty simple to set up a hook to run for this (or some similar mechanism). :)

Pcoombe subscribed.May 30 2018, 1:22 PM
• Imarlier subscribed.May 31 2018, 2:25 PM

@AndyRussG Would mw.centralNotice.isBannerShown() give us the value that we want?

• Gilles claimed this task.Jun 1 2018, 11:57 AM
• Gilles triaged this task as Medium priority.Jun 1 2018, 12:06 PM
gerritbot subscribed.Jun 1 2018, 1:24 PM

Change 436792 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/CentralNotice@master] Add performance mark for when banner is inserted

https://gerrit.wikimedia.org/r/436792

gerritbot added a project: Patch-For-Review.Jun 1 2018, 1:24 PM
• Gilles moved this task from To-do: Goals prioritized current Quarter to Doing (old) on the Performance-Team board.Jun 1 2018, 1:24 PM
• Gilles added a parent task: T187299: User-perceived page load performance study.Jun 1 2018, 2:00 PM
• Gilles mentioned this in T187299: User-perceived page load performance study.Jun 5 2018, 2:30 PM
gerritbot added a comment.Jun 15 2018, 4:05 PM

Change 436792 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Add performance mark for when banner is inserted

https://gerrit.wikimedia.org/r/436792

Krinkle removed a project: Patch-For-Review.Jun 22 2018, 3:13 PM
• Vvjjkkii renamed this task from Track when a CentralNotice banner was displayed to the user in NavTiming to b3baaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii removed • Gilles as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from b3baaaaaaa to Track when a CentralNotice banner was displayed to the user in NavTiming.Jul 2 2018, 1:52 PM
CommunityTechBot assigned this task to • Gilles.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
• Gilles added a comment.Sep 3 2018, 12:13 PM

Hmmm I'm targeted by a WLM banner right now and I'm not seeing the performance mark...

• Gilles added a comment.Sep 3 2018, 12:20 PM

My code doesn't seem to be running on enwiki? @AndyRussG Are new versions of CentralNotice not deployed automatically via the train like the rest of MediaWiki extensions? Special:Version on enwiki states "2.6.0 (6492626) 20:21, 6 May 2018".

Krinkle added a project: Wikimedia-Fundraising.Sep 3 2018, 7:49 PM
• Gilles moved this task from Doing (old) to Blocked (old) on the Performance-Team board.Sep 3 2018, 8:28 PM
• Gilles added a subscriber: Ejegg.Sep 6 2018, 12:07 PM

@Ejegg when is the next CentralNotice deployment scheduled? If not scheduled or far in the future, is there any chance this particular change could be backported to production? It's extremely low risk: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/436792/1/resources/subscribing/ext.centralNotice.display.js

AndyRussG added a comment.Sep 13 2018, 2:53 PM

@Gilles Apologies for the delay... Is it ok with you if this goes on next week's deployment train? (Also replied to your e-mail... Apologies again!!!)

• Gilles added a comment.Sep 13 2018, 4:32 PM

Yes, next train is totally fine, thanks!

gerritbot added a comment.Sep 18 2018, 3:58 PM

Change 461151 had a related patch set uploaded (by AndyRussG; owner: Gilles):
[mediawiki/extensions/CentralNotice@wmf_deploy] Add performance mark for when banner is inserted

https://gerrit.wikimedia.org/r/461151

gerritbot added a project: Patch-For-Review.Sep 18 2018, 3:58 PM
gerritbot added a comment.Sep 18 2018, 4:26 PM

Change 461151 merged by AndyRussG:
[mediawiki/extensions/CentralNotice@wmf_deploy] Add performance mark for when banner is inserted

https://gerrit.wikimedia.org/r/461151

Addshore subscribed.Sep 18 2018, 4:34 PM

It looks like this has been merged but left un deployed on the wmf.20 branch?

gerritbot added a comment.Sep 19 2018, 10:56 PM

Change 461485 had a related patch set uploaded (by AndyRussG; owner: Gilles):
[mediawiki/extensions/CentralNotice@wmf_deploy] Add performance mark for when banner is inserted

https://gerrit.wikimedia.org/r/461485

gerritbot added a comment.Sep 20 2018, 6:20 PM

Change 461485 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Add performance mark for when banner is inserted

https://gerrit.wikimedia.org/r/461485

Stashbot subscribed.Sep 20 2018, 7:12 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-20T19:12:25Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.22/extensions/CentralNotice/resources/subscribing/ext.centralNotice.display.js: SWAT: [[gerrit:461485|Add performance mark for when banner is inserted]] T195840 (duration: 00m 51s)

• Gilles added a comment.Sep 20 2018, 7:28 PM

This is now live. From the enwiki main page:

Capture d'écran 2018-09-20 21.27.18.png (206×707 px, 37 KB)

Next step is to capture the mark and record it in NavigationTiming data (or in a new schema linked to navtiming via pageviewToken).

• Gilles removed a project: Patch-For-Review.Sep 20 2018, 7:28 PM
• Gilles moved this task from Blocked (old) to Doing (old) on the Performance-Team board.
Peter subscribed.Sep 24 2018, 5:38 PM

@Gilles I've added the User Timing the WebPageTest dashboard: https://grafana.wikimedia.org/dashboard/db/webpagetest-drilldown?panelId=47&fullscreen&orgId=1

Also added a actual measurement of the Central notice element: https://grafana.wikimedia.org/dashboard/db/webpagereplay-drilldown?orgId=1

AndyRussG added a comment.Sep 25 2018, 4:04 PM

@Peter, @Gilles, looks great!!! :)

gerritbot added a comment.Sep 26 2018, 4:51 PM

Change 463113 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/NavigationTiming@master] Record mwCentralNoticeBanner in CentralNoticeTiming

https://gerrit.wikimedia.org/r/463113

gerritbot added a project: Patch-For-Review.Sep 26 2018, 4:51 PM
gerritbot added a comment.Oct 1 2018, 9:30 PM

Change 463113 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Record mwCentralNoticeBanner in CentralNoticeTiming

https://gerrit.wikimedia.org/r/463113

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 1 2018, 10:00 PM
• Gilles closed this task as Resolved.Oct 4 2018, 10:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL