Maniphest T195904

[BUG] Languages names are not searchable in the device language if language is not English
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	May 29 2018, 6:55 PM

Description

Bug discovered during user testing in T192891
This appears to be a regression (the current production app finds language names in the device language)

Steps to reproduce

Pre-requisite: the device language is not English, eg., device lang=Dansk

With the device language set to another langauge, eg Danish, open the app and navigate to add an app language
Search to add German as as an app language, but enter the Danish name for German "Tysk".

Expected

Result shown is Deutsch / Tysk
https://phabricator.wikimedia.org/T195904

Note the production version of the app shows the expected result:

Actual

No results. Only searching for the language in its own name "Deutsch" or in English "German" returns a result.

Details

	Subject	Repo	Branch	Lines +/-
	Use device language, not app language, when localizing language names.	apps/android/wikipedia	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned Here: T192891: Perform user testing on new multilingual features at Hackathon

Event Timeline

RHo created this task.May 29 2018, 6:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2018, 6:55 PM

RHo updated the task description. (Show Details)May 29 2018, 7:33 PM

@RHo What is your primary *app* language when going to search the list of languages? The localized language names follow the topmost language selected in the app, not the primary device language. Are we saying that the language search should correspond to the device language, not the app language?

In T195904#4240895, @Dbrant wrote:

@RHo What is your primary *app* language when going to search the list of languages? The localized language names follow the topmost language selected in the app, not the primary device language. Are we saying that the language search should correspond to the device language, not the app language?

hi @Dbrant - Yes, since we are following the principle that the app's UI language uses the device language.

Change 436167 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Use device language, not app language, when localizing language names.

https://gerrit.wikimedia.org/r/436167

gerritbot added a project: Patch-For-Review.May 29 2018, 8:42 PM

Dbrant claimed this task.May 29 2018, 8:43 PM

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.24x-I-Ice-lolly on the Wikipedia-Android-App-Backlog board.

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly); removed Wikipedia-Android-App-Backlog.

Dbrant moved this task from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.

Change 436167 merged by jenkins-bot:
[apps/android/wikipedia@master] Use device language, not app language, when localizing language names.

https://gerrit.wikimedia.org/r/436167

Dbrant moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 4 2018, 9:52 PM

Looks good to me on 2.7.234-alpha-2018-06-07

Dbrant closed this task as Resolved.Jun 27 2018, 8:04 PM

• Vvjjkkii renamed this task from [BUG] Languages names are not searchable in the device language if language is not English to j1baaaaaaa.Jul 1 2018, 1:07 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Dbrant as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from j1baaaaaaa to [BUG] Languages names are not searchable in the device language if language is not English.Jul 2 2018, 3:20 PM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Dbrant.

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

[BUG] Languages names are not searchable in the device language if language is not EnglishClosed, ResolvedPublicActions