Page MenuHomePhabricator

Temporarily enable MFMobileMainPageCss in Russian Wikipedia
Closed, ResolvedPublic

Description

After the conversation in T138622, I’ve decided that there is a need to have some permanent styling applied before mobile main page can be loaded in Russian Wikipedia. We are getting rid of main page special casing, but given the nature of a new main page we have to have some on-render styles that TemplateStyles currently can’t provide.

Basically, I need to put the code for changing the page background (see below) somewhere before T195813 can be resolved, and I don’t think that T195813 would be resolved without coming up with some better solution that Russian Wikipedia can also use in near future. I am planning the deployment of new main page on 1 June, so I would like to have the feedback on this from mobile developers before the next deployment train.

I am already subscribed to the task about the deprecation and would be more than ready and capable to assist when the other solution to this problem would come in the future.

@media (max-width: 719px) {
.skin-minerva .header-container.header-chrome { box-shadow:none; }
.skin-minerva #content { background-color:#eaecf0; }
}

Event Timeline

This should be a trivial feature flag switch, so you shouldn't need my help to enable this. Anyone should feel free to SWAT the config change.

@stjn when deploying this new design, please use TemplateStyles for styling where possible. The smaller MediaWiki:MobileMainpage is the easier it will be to avoid breakage!

Change 436310 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Temporarily enable MFMobileMainPageCss in ruwiki

https://gerrit.wikimedia.org/r/436310

Patch uploaded. When should this be reverted?

Urbanecm triaged this task as Medium priority.May 30 2018, 5:31 PM
Urbanecm moved this task from Backlog to To deploy on the User-Urbanecm board.

Seems like Normal priority. If anybody should think this is lower/hígher priority, feel free to discuss about it (or change it with comment, if sure enough).

Patch uploaded. When should this be reverted?

What do you mean exactly? This will be reverted when a better approach would be developed in T195946 (or if mobile team decides so).

The task title says "Temporarily enable", so I expect it should not be permanent, but time limited. That's the reason why I asked about revert time. Tasks that are time limited are usually closed after reverting, not after enabling, because the scope of the task is bigger than just enable it. To make it temporary, it should be also disabled again.

This is, as far as I can understand it, different. The disabling is blocked on development, not some time (for example, profiling of Abuse Filters can be enabled, but because it takes time and it is usually only needed for evaluation, it is disabled after some time).

So, I'd suggest to close this task after it will be enabled and if the task linked is resolved, somebody will fill a new task saying "we do not need this, disable it" and then the handling in extension's code can be removed (too dedicated task).

Your opinion?

Agree with your analysis. I meant ‘temporarily’ as referring more to the nature of this feature, which is uncertain at the moment until the necessary discussions will happen and something will be decided on a larger scale.

stjn raised the priority of this task from Medium to High.May 31 2018, 10:13 PM

I hope you don’t mind that I raise the priority, I wanted this to happen before June 1 specifically for the reason that it would be easier to deploy the new main page in RuWP today at night (MSK).

There are no swats allowed on Friday so you may have to delay your update till monday. I can help you with that if necessary on Monday.

stjn lowered the priority of this task from High to Medium.Jun 1 2018, 7:46 AM

I’ve already deployed the new main page, I’d guess people on 3G would have to suffer a bit, but this is really rather an unfortunate turn of events so I don’t want to put on brakes just because of this.

Well... Only UBN tasks are eglible to be deployed out of schedule. So, I'd schedule it for deploy on Monday

Change 436310 merged by jenkins-bot:
[operations/mediawiki-config@master] Temporarily enable MFMobileMainPageCss in ruwiki

https://gerrit.wikimedia.org/r/436310

Mentioned in SAL (#wikimedia-operations) [2018-06-04T13:16:58Z] <zfilipin@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:436310|Temporarily enable MFMobileMainPageCss in ruwiki (T195905)]] (duration: 00m 50s)

Deployed. Should it be broken, please reopen&comment.

Vvjjkkii renamed this task from Temporarily enable MFMobileMainPageCss in Russian Wikipedia to i1baaaaaaa.Jul 1 2018, 1:07 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Urbanecm as the assignee of this task.
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from i1baaaaaaa to Temporarily enable MFMobileMainPageCss in Russian Wikipedia.Jul 2 2018, 2:46 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Urbanecm.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: gerritbot, Aklapper.