Maniphest T195906

Phan fails for Wikibase on wmf.x branches
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	thcipriani
	May 29 2018, 7:13 PM

Description

Currently blocking the backport of: https://gerrit.wikimedia.org/r/#/q/801c39d3fe6500fb0eb4a5767d5987f9ba78107c

Which is, in turn, blocking other backports which is, in turn, blocking the wmf.5 train.

From IRC:

<legoktm> Wikibase's phan config only loads the Babel/PageImages phan stubs if extensions/Babel (etc.) is not a directory
<legoktm> but on wmf/ branches that is always a directory since it's a submodule
<legoktm> maybe it should check for some thing like file_exists(extensions/Babel/extension.json)

Details

	Subject	Repo	Branch	Lines +/-
	Always use extension stubs for phan	mediawiki/extensions/Wikibase	master	+31 -41

Customize query in gerrit

Related Objects

Mentioned In: T200508: Run WikibaseLexeme tests with Wikibase CI
T199449: phan failing for Wikibase on wmf. branches
T195514: Can't copy and paste a list on office.wiki page in the visual editor
T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'
Mentioned Here: T200508: Run WikibaseLexeme tests with Wikibase CI
T195514: Can't copy and paste a list on office.wiki page in the visual editor
T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'

Event Timeline

thcipriani created this task.May 29 2018, 7:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2018, 7:13 PM

thcipriani added a parent task: T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'.May 29 2018, 7:13 PM

thcipriani mentioned this in T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'.

Mentioned in SAL (#wikimedia-operations) [2018-05-29T19:16:40Z] <thcipriani> cutting branch for wmf.6, will not deploy wmf.6 as wmf.5 is not currently on group2 as the train is blocked on T195514 which is blocked on T195868 which is blocked on T195906

Setting UBN! as this is a blocker of the blocker of the blocker of the train for wmf.5

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMay 29 2018, 7:18 PM

Peachey88 updated the task description. (Show Details)May 29 2018, 7:45 PM

Krinkle added a project: Wikidata.May 29 2018, 7:57 PM

[12:01:38] <legoktm> thcipriani: I know why it's failing, I have no idea why it passed previously
[12:02:01] <legoktm> Wikibase's phan config only loads the Babel/PageImages phan stubs if extensions/Babel (etc.) is not a directory
[12:02:15] <legoktm> but on wmf/ branches that is always a directory since it's a submodule
[12:02:32] <legoktm> maybe it should check for some thing like file_exists(extensions/Babel/extension.json)

Lowering priority as I force-merged the patch that blocked train.

thcipriani removed a parent task: T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'.May 29 2018, 8:15 PM

Jdforrester-WMF subscribed.May 29 2018, 8:51 PM

Krinkle removed a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Jun 15 2018, 12:00 AM

• Vvjjkkii renamed this task from Phan fails for Wikibase on wmf.x branches to h1baaaaaaa.Jul 1 2018, 1:07 AM

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from h1baaaaaaa to Phan fails for Wikibase on wmf.x branches.Jul 2 2018, 1:03 PM

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Change 446809 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Wikibase@master] Always use extension stubs for phan

https://gerrit.wikimedia.org/r/446809

gerritbot added a project: Patch-For-Review.Jul 19 2018, 1:11 PM

Change 446809 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Always use extension stubs for phan

https://gerrit.wikimedia.org/r/446809

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 20 2018, 2:00 PM

Legoktm closed this task as Resolved.Jul 20 2018, 2:16 PM

Legoktm claimed this task.

Liuxinyu970226 unsubscribed.Jul 24 2018, 7:14 AM

WMDE-leszek mentioned this in T199449: phan failing for Wikibase on wmf. branches.Jul 25 2018, 7:07 AM

Addshore subscribed.Jul 27 2018, 12:53 PM

This comment was removed by Addshore.

Addshore mentioned this in T200508: Run WikibaseLexeme tests with Wikibase CI.Jul 27 2018, 12:53 PM