Maniphest T195908

FundraiserLandingPage: Parse EL sample rate URL param as number
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This is the same issue we had with the impresion EventLogging feature in CentralNotice: we need to parse the URL parameter as a number, otherwise it is sent as a string in the EventLogging event, which does not conform to the event schema.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/FundraiserLandingPage	master	+3 -3	Parse EL sample rate URL param as number

Customize query in gerrit

Event Timeline

AndyRussG created this task.May 29 2018, 7:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2018, 7:38 PM

Change 436095 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/FundraiserLandingPage@master] Parse EL sample rate URL param as number

https://gerrit.wikimedia.org/r/436095

gerritbot added a project: Patch-For-Review.May 29 2018, 7:46 PM

AndyRussG added a project: Fundraising Sprint Karma chameleons hide amongst us.May 29 2018, 7:46 PM

AndyRussG set the point value for this task to 1.

AndyRussG moved this task from Backlog to Review on the Fundraising Sprint Karma chameleons hide amongst us board.

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.May 29 2018, 7:59 PM

Change 436095 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@master] Parse EL sample rate URL param as number

https://gerrit.wikimedia.org/r/436095

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 1 2018, 6:00 PM

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Karma chameleons hide amongst us board.Jun 4 2018, 6:58 PM

• DStrine added a project: Fundraising Sprint Lactose is unusually tolerant.Jun 5 2018, 8:33 PM

AndyRussG moved this task from Backlog to Pending Deployment on the Fundraising Sprint Lactose is unusually tolerant board.Jun 5 2018, 9:31 PM