Page MenuHomePhabricator

Article Preview Popups trigger on keypress when link is ctrlclicked
Open, LowPublic

Description

Steps to Reproduce:

  1. If Logged in, enable Page Previews (Preferences > Appearances > Page Previews => Enable)
  2. https://en.wikipedia.org/wiki/Major_League_Baseball with Chrome 67.xx
  3. Ctrl + Click any link to open in new tab
  4. Move mouse off of link.
  5. Use down arrow to scroll page.

Actual Results:
Selected pop-up will appear despite actual location of mouse. If mouse is previewing another link, new pop-up will close and original pop-up will reappear.

Expected Results:
No action.
Escape key should clear out all pop-ups.

Event Timeline

Hi @DeanLo, thanks for taking the time to report this and welcome to Phabricator!
Removing Navigation-Popups-Gadget as that gadget seems to not be involved.

ovasileva moved this task from Backlog to Hovercards Pt2 on the Page-Previews board.
Vvjjkkii renamed this task from Article Preview Popups trigger on keypress when link is ctrlclicked to o0baaaaaaa.Jul 1 2018, 1:07 AM
Vvjjkkii raised the priority of this task from Low to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
JJMC89 renamed this task from o0baaaaaaa to Article Preview Popups trigger on keypress when link is ctrlclicked.Jul 1 2018, 2:10 AM
JJMC89 lowered the priority of this task from High to Low.
JJMC89 updated the task description. (Show Details)
JJMC89 added a subscriber: Aklapper.

I don't believe I'm understanding the bug here. Is it possible to record a screencast or make a gif?

Aklapper changed the task status from Open to Stalled.Aug 29 2018, 11:16 AM

@DeanLo :

  1. Ctrl + Click any link to open in new tab

That opens a new tab in the background.

  1. Press any non-function key on keyboard

Actual Results:
Selected pop-up will appear despite actual location of mouse.

The instructions above do not include any mouse movement. So the mouse is still over the link which I clicked on the original page. Hence the popup is still shown and no popup "will appear". So the provided steps do not work here, or lack something.

Currently I don't see any unexpected behavior described.

Sorry, should clarify. I see how "... despite actual location of mouse" could be unclear since it is not explicit in the steps.

  1. Move mouse off of the link (thus disengaging popup).
  1. Press any non-function key on keyboard.

If you are scrolling with the keyboard controls, the popup will reappear despite the mouse no longer hovering over it. The popup obscures content that might still be mid-consumption.

Aklapper changed the task status from Stalled to Open.Aug 29 2018, 1:46 PM

Thanks for clarifying! Confirming with the steps in the updated task description.