Page MenuHomePhabricator

Can't load page for non-existing files
Closed, ResolvedPublic

Description

Instead of seeing the "No file by this name exists" page, an exception is thrown.
E.g. https://federated-commons.wmflabs.org/wiki/File:Non-existing.jpg

Original exception: [83756da7024c10f173ce2abb] /wiki/File:Non-existing.jpg InvalidArgumentException from line 41 of /var/www/w/extensions/WikibaseMediaInfo/src/DataModel/MediaInfoId.php: $idSerialization must match /^M[1-9]\d{0,9}\z/i
Backtrace:
#0 /var/www/w/extensions/WikibaseMediaInfo/src/DataModel/MediaInfoId.php(28): Wikibase\MediaInfo\DataModel\MediaInfoId->assertValidIdFormat(string)
#1 /var/www/w/extensions/WikibaseMediaInfo/WikibaseMediaInfo.entitytypes.php(122): Wikibase\MediaInfo\DataModel\MediaInfoId->__construct(string)
#2 /var/www/w/extensions/Wikibase/vendor/wikibase/data-model-services/src/EntityId/EntityIdComposer.php(62): Wikibase\MediaInfo\WikibaseMediaInfoHooks::{closure}(string, integer)
#3 /var/www/w/extensions/WikibaseMediaInfo/src/WikibaseMediaInfoHooks.php(115): Wikibase\DataModel\Services\EntityId\EntityIdComposer->composeEntityId(string, string, integer)
#4 [internal function]: Wikibase\MediaInfo\WikibaseMediaInfoHooks::onBeforePageDisplay(OutputPage, SkinVector)
#5 /var/www/w/includes/Hooks.php(177): call_user_func_array(string, array)
#6 /var/www/w/includes/Hooks.php(237): Hooks::callHook(string, string, array, NULL, string)
#7 /var/www/w/includes/OutputPage.php(2460): Hooks::runWithoutAbort(string, array)
#8 /var/www/w/includes/MediaWiki.php(870): OutputPage->output(boolean)
#9 /var/www/w/includes/MediaWiki.php(882): MediaWiki->{closure}()
#10 /var/www/w/includes/MediaWiki.php(524): MediaWiki->main()
#11 /var/www/w/index.php(42): MediaWiki->run()
#12 {main}

Event Timeline

Change 436295 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix exception for non-existing files

https://gerrit.wikimedia.org/r/436295

Change 436295 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix exception for non-existing files

https://gerrit.wikimedia.org/r/436295

Vvjjkkii renamed this task from Can't load page for non-existing files to vzbaaaaaaa.Jul 1 2018, 1:06 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed matthiasmullie as the assignee of this task.
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from vzbaaaaaaa to Can't load page for non-existing files.Jul 2 2018, 4:24 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to matthiasmullie.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: gerritbot, Aklapper.