Page MenuHomePhabricator
Create Task
Maniphest T195981

the package resource should mark packages as manually installed
Closed, ResolvedPublic
Actions

Description

In the following scenario, important packages can end up in the list of apt-get autoremove candidates:

  • Package A is installed, either by hand or with puppet. Package A depends on B, hence B gets installed and marked as being automatically installed
  • Package B is needed for a certain reason, and a puppet manifest with require_package('B') is added. B is already installed, hence nothing much happens
  • Package A isn't necessary anymore and it gets removed
  • apt-get autoremove considers B for removal as it is apt-marked as auto

This problem can be fixed by making require_package mark packages as manually installed (apt-mark manual $pkg) if they weren't already.

Related Objects
Search...

Event Timeline

• ema created this task.May 30 2018, 3:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2018, 3:11 PM
• ema triaged this task as Medium priority.May 30 2018, 3:11 PM
• ema updated the task description. (Show Details)
MoritzMuehlenhoff added a comment.May 30 2018, 3:21 PM

Ack, the analysis and the proposed fix seem entirely correct.

• ema added a comment.May 30 2018, 4:08 PM

There's an open upstream bug for this too: https://tickets.puppetlabs.com/browse/PUP-6631

• Vvjjkkii renamed this task from require_package should mark packages as manually installed to ezbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from ezbaaaaaaa to require_package should mark packages as manually installed.Jul 2 2018, 2:26 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
• Phabricator_maintenance moved this task from Backlog to Acknowledged on the SRE board.Jan 26 2019, 10:02 PM
jbond subscribed.Oct 15 2019, 8:51 AM
jbond added a project: User-jbond.Oct 30 2019, 6:00 PM
jbond moved this task from Unsorted 💣 to Friday tasks on the User-jbond board.Oct 30 2019, 6:10 PM
jbond added a comment.Nov 5 2019, 12:56 PM

I attempted a patch for this upstream although its not quite working yet

jbond added a comment.Jul 23 2020, 11:46 AM
In T195981#5635590, @jbond wrote:

I attempted a patch for this upstream although its not quite working yet

merged

MoritzMuehlenhoff added a comment.Jul 24 2020, 1:27 PM

Fantastic :-)

• ema added a comment.Jul 24 2020, 3:16 PM
In T195981#6329235, @jbond wrote:
In T195981#5635590, @jbond wrote:

I attempted a patch for this upstream although its not quite working yet

merged

You rock.

jbond mentioned this in T265138: Work required to prepare for puppet 7.Oct 9 2020, 1:06 PM
jbond added a parent task: T265138: Work required to prepare for puppet 7.
Dzahn subscribed.Dec 4 2020, 10:25 PM

We are removing require_package across the board now in T266479.

Aklapper added a project: Infrastructure-Foundations.Jun 21 2021, 9:00 PM
jbond closed this task as Resolved.Nov 3 2021, 12:04 PM
jbond claimed this task.

reqiure_package has been removed

MoritzMuehlenhoff added a comment.Nov 3 2021, 1:29 PM
In T195981#7477405, @jbond wrote:

reqiure_package has been removed

But ensure_packages has the same issue, hasn't it?

jbond reopened this task as Open.EditedNov 4 2021, 9:15 PM
In T195981#7477690, @MoritzMuehlenhoff wrote:
In T195981#7477405, @jbond wrote:

reqiure_package has been removed

But ensure_packages has the same issue, hasn't it?

re-opening, i think the answer is i need to double check. i think there was some further progress on the patch i did above (by others) but need to check where/how it landed

we should also raise an upstream bug as well if it is

jbond renamed this task from require_package should mark packages as manually installed to ensure_packages should mark packages as manually installed.Nov 4 2021, 9:15 PM
jbond renamed this task from ensure_packages should mark packages as manually installed to the package resource should mark packages as manually installed.Nov 4 2021, 9:17 PM

have updated the title, the underlining issue is actually with the apt provider for the package type

jbond edited projects, added: Puppet-Core; removed: SRE, Puppet.Jun 12 2023, 5:12 PM
jbond mentioned this in T330490: Next steps for Puppet 7.Jul 3 2023, 3:38 PM
jhathaway subscribed.Nov 20 2023, 4:12 PM

Updated link, https://puppet.atlassian.net/browse/PUP-6631

jbond closed this task as Resolved.Nov 20 2023, 4:21 PM

this has been fixed upstream we should get the benefit when we upgrade to puppet7

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits