Maniphest T196002

Test server never shuts down after 'npm run test:diff', must be manually SIGTERM'd
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mholloway
	May 30 2018, 7:12 PM

Description

When running just the diff tests with npm run test:diff, the server never shuts down. Let's figure out why, because I run this very frequently, and having to continually ctrl-C is annoying.

Details

	Subject	Repo	Branch	Lines +/-
	Use old mocha exit behavior for test:diff	mediawiki/services/mobileapps	master	+1 -1

Customize query in gerrit

Event Timeline

• Mholloway created this task.May 30 2018, 7:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2018, 7:12 PM

• Mholloway added a project: Mobile-Content-Service.May 30 2018, 7:49 PM

Theoretically this is accomplished by adding after(() => server.stop()); in test/diff/diff.js. That's easier to do without side effects if the diff tests run stand-alone.
Otherwise the server stops prematurely, if other tests follow.

LGoto triaged this task as Low priority.May 31 2018, 5:53 PM

LGoto moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.

• Vvjjkkii renamed this task from Test server never shuts down after 'npm run test:diff', must be manually SIGTERM'd to tybaaaaaaa.Jul 1 2018, 1:06 AM

• Vvjjkkii raised the priority of this task from Low to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from tybaaaaaaa to Test server never shuts down after 'npm run test:diff', must be manually SIGTERM'd .Jul 2 2018, 8:43 AM

CommunityTechBot lowered the priority of this task from High to Low.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Change 443868 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Use old mocha exit behavior for test:diff

https://gerrit.wikimedia.org/r/443868

gerritbot added a project: Patch-For-Review.Jul 4 2018, 10:55 PM

See here for background on the fix: https://github.com/chaijs/chai-http/issues/178#issuecomment-336602457

Jdforrester-WMF assigned this task to • Mholloway.Jul 5 2018, 5:38 PM

Jdforrester-WMF edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Patch-For-Review, Product-Infrastructure-Team-Backlog-Deprecated.

Jdforrester-WMF moved this task from To Do to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

• Jhernandez closed this task as Resolved.Jul 5 2018, 7:12 PM

Change 443868 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Use old mocha exit behavior for test:diff

https://gerrit.wikimedia.org/r/443868