Page MenuHomePhabricator

Create an error message to better report about failings of maps with complex GeoJSON
Open, NormalPublic

Description

T193458 describes a situation where complex maps have begun failing. While we look for an answer to why this began happening recently. In the task, @Catrope makes the following suggestions:

  • We need better error messages for this case. "Invalid GeoJSON" is not what really happened if we had a timeout looking up the shapes.
  • Paul suggested looking at the GeoJSON that this lookup tries to generate. 200+ highways might correspond to megabytes of GeoJSON. That can be OK for static map generation, but won't be OK for in-browser dynamic maps where all that data needs to be downloaded to and rendered by the client.

I'm not sure exactly what error message will be required, but am happy to consult when someone can tell me exactly what the situation that triggers the message is.

Event Timeline

Catrope updated the task description. (Show Details)Jun 4 2018, 5:59 PM

Can we have more error messages ?

  • Json not created- size overflow.
  • Duplicate QID mapped

Invalid Geojson is too generic for all error messages.

Change 443119 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mapdata@master] [WIP] DataManager unit tests

https://gerrit.wikimedia.org/r/443119

Vvjjkkii renamed this task from Create an error message to better report about failings of maps with complex GeoJSON to gybaaaaaaa.Jul 1 2018, 1:07 AM
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
AfroThundr3007730 renamed this task from gybaaaaaaa to Create an error message to better report about failings of maps with complex GeoJSON.Jul 1 2018, 6:17 AM
AfroThundr3007730 updated the task description. (Show Details)
AfroThundr3007730 added subscribers: GerritBot, Aklapper.

Change 443119 abandoned by Sbisson:
[WIP] DataManager unit tests

Reason:
Please restore if/when you want to do something with it.

https://gerrit.wikimedia.org/r/443119

Jhernandez edited projects, added Maps (Maps-data); removed Maps.Aug 7 2018, 3:32 PM
Jhernandez edited projects, added Maps (Kartographer); removed Maps (Maps-data).
Jhernandez lowered the priority of this task from High to Normal.
MSantos moved this task from Unsorted to General on the Maps (Kartographer) board.
MSantos moved this task from Backlog to To-do on the Maps-Sprint board.Sep 18 2018, 6:17 PM