Page MenuHomePhabricator
Create Task
Maniphest T196023

Attempt to change skins throwing error on MediaWiki.org
Closed, ResolvedPublic
Actions

Description

While logged in, when I change the skin and hit Save at https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-rendering I receive the following error:

Error
Our servers are currently under maintenance or experiencing a technical problem. Please try again in a few minutes.

See the error message at the bottom of this page for more information.

If you report this error to the Wikimedia System Administrators, please include the details below.

PHP fatal error: 
Argument 2 passed to GlobalPreferences\Hooks::onPreferencesFormPreSave() must be an instance of PreferencesForm, PreferencesFormLegacy given

Details

SubjectRepoBranchLines +/-
Don't type hint PreferencesFormPreSave hook against PreferencesFormmediawiki/extensions/GlobalPreferencesmaster+3 -3
Don't type hint PreferencesFormPreSave hook against PreferencesFormmediawiki/extensions/GlobalPreferenceswmf/1.32.0-wmf.6+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

dr0ptp4kt created this task.May 30 2018, 9:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2018, 9:24 PM
• TBolliger moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.May 30 2018, 9:26 PM
Legoktm triaged this task as Unbreak Now! priority.May 30 2018, 10:07 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMay 30 2018, 10:07 PM
Legoktm added a parent task: T191052: 1.32.0-wmf.6 deployment blockers.May 30 2018, 10:07 PM
gerritbot added a subscriber: gerritbot.May 30 2018, 10:12 PM

Change 436411 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/GlobalPreferences@master] Don't type hint PreferencesFormPreSave hook against PreferencesForm

https://gerrit.wikimedia.org/r/436411

gerritbot added a project: Patch-For-Review.May 30 2018, 10:12 PM
gerritbot added a comment.May 30 2018, 10:14 PM

Change 436413 had a related patch set uploaded (by Thcipriani; owner: Legoktm):
[mediawiki/extensions/GlobalPreferences@wmf/1.32.0-wmf.6] Don't type hint PreferencesFormPreSave hook against PreferencesForm

https://gerrit.wikimedia.org/r/436413

gerritbot added a comment.May 30 2018, 10:16 PM

Change 436413 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@wmf/1.32.0-wmf.6] Don't type hint PreferencesFormPreSave hook against PreferencesForm

https://gerrit.wikimedia.org/r/436413

Stashbot added a subscriber: Stashbot.May 30 2018, 10:22 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-30T22:22:24Z] <thcipriani@tin> Synchronized php-1.32.0-wmf.6/extensions/GlobalPreferences/includes/Hooks.php: SWAT: [[gerrit:436413|Do not type hint PreferencesFormPreSave hook against PreferencesForm]] T196023 (duration: 01m 22s)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 30 2018, 11:00 PM
gerritbot added a comment.May 31 2018, 5:18 PM

Change 436411 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Don't type hint PreferencesFormPreSave hook against PreferencesForm

https://gerrit.wikimedia.org/r/436411

dr0ptp4kt added a comment.May 31 2018, 5:22 PM

Thanks, all. It's working for me now.

Legoktm closed this task as Resolved.May 31 2018, 5:49 PM
Legoktm claimed this task.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)); removed MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 31 2018, 6:00 PM
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jun 6 2018, 4:31 AM
• Vvjjkkii renamed this task from Attempt to change skins throwing error on MediaWiki.org to 8xbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Legoktm as the assignee of this task.
• Vvjjkkii lowered the priority of this task from Unbreak Now! to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: Legoktm; removed: gerritbot, Aklapper.
thcipriani renamed this task from 8xbaaaaaaa to Attempt to change skins throwing error on MediaWiki.org.Jul 1 2018, 7:42 PM
thcipriani closed this task as Resolved.
thcipriani assigned this task to Legoktm.
thcipriani updated the task description. (Show Details)
thcipriani removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, CheckUser.
thcipriani raised the priority of this task from High to Unbreak Now!.Jul 1 2018, 7:43 PM
thcipriani added subscribers: gerritbot, Aklapper.
Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL