Page MenuHomePhabricator
Create Task
Maniphest T196033

Clean up RCFilters preference tech debt once watchlist is out of beta
Closed, ResolvedPublic
Actions

Description

Possibly incomplete list of things to clean up:

  • Default $wgStructuredChangeFiltersShowPreference to true, and/or deprecate it, and/or remove it
  • Same for $wgStructuredChangeFiltersShowWatchlistPreference
  • Same for $wgStructuredChangeFiltersOnWatchlist
  • Remove beta feature code in WikimediaMessages, including $wgEnableRcFiltersBetaFeature
  • Remove the RcFiltersInvite guided tour in WikimediaMessages

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+0 -1Remove rcenhancedfilters from $wgDefaultUserOptions
mediawiki/extensions/ORESmaster+0 -1Remove all references to rcenhancedfilters
operations/mediawiki-configmaster+0 -1Remove rcenhancedfilters from beta features whitelist
operations/mediawiki-configmaster+0 -15Remove config for RCFilters variables being removed from Core
mediawiki/coremaster+0 -10Remove unused function: isStructuredFilterUiEnabledByDefault
mediawiki/coremaster+38 -75Remove temporary rcfilters variables
mediawiki/extensions/WikimediaMessagesmaster+1 -464Remove rcfilters beta features and related tours
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope triaged this task as Medium priority.May 31 2018, 1:21 AM
Catrope created this task.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 31 2018, 1:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope updated the task description. (Show Details)May 31 2018, 1:50 AM
Aklapper added a project: Technical-Debt.May 31 2018, 10:38 AM
Catrope added a subtask: T195029: Retire $wgStructuredChangeFiltersShowPreference.May 31 2018, 8:30 PM
Catrope updated the task description. (Show Details)Jun 1 2018, 9:11 PM
JTannerWMF moved this task from Untriaged to Blocked / Awaiting info on the Collaboration-Team-Triage board.Jun 5 2018, 6:03 PM
• Vvjjkkii renamed this task from Clean up RCFilters preference tech debt once watchlist is out of beta to yxbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, archived--TCB-Team.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from yxbaaaaaaa to Clean up RCFilters preference tech debt once watchlist is out of beta.Jul 2 2018, 2:18 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: archived--TCB-Team, Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Catrope added a project: Growth-Team (Current Sprint).Jul 5 2018, 6:11 PM
Catrope edited projects, added Growth-Team; removed Growth-Team (Current Sprint).
Catrope moved this task from Inbox to Upcoming Work on the Growth-Team board.
JTannerWMF moved this task from Upcoming Work to Current Sprint on the Growth-Team board.Jul 18 2018, 3:12 PM
JTannerWMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
JTannerWMF moved this task from Ready for Development to Incoming on the Growth-Team (Current Sprint) board.Aug 1 2018, 5:40 PM
MMiller_WMF edited projects, added Growth-Team; removed Growth-Team (Current Sprint), Collaboration-Team-Triage.Aug 9 2018, 5:47 PM
MMiller_WMF moved this task from Inbox to Needs Discussion/Analysis on the Growth-Team board.
kostajh moved this task from Needs Discussion/Analysis to Upcoming Work on the Growth-Team board.Sep 18 2018, 7:03 PM
kostajh added a subscriber: kostajh.

Watchlist is out of beta. We'd like to do this in Q2/Q3.

kostajh moved this task from Upcoming Work to FY 2019-20 on the Growth-Team board.Sep 18 2018, 7:12 PM
JTannerWMF moved this task from FY 2019-20 to Current Sprint on the Growth-Team board.Sep 26 2018, 6:29 PM
JTannerWMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
SBisson claimed this task.Sep 27 2018, 3:22 PM
SBisson moved this task from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
gerritbot added a subscriber: gerritbot.Sep 27 2018, 5:09 PM

Change 463315 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/WikimediaMessages@master] Remove rcfilters beta features and related tours

https://gerrit.wikimedia.org/r/463315

gerritbot added a project: Patch-For-Review.Sep 27 2018, 5:09 PM
gerritbot added a comment.Sep 27 2018, 5:11 PM

Change 463317 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] Remove temporary rcfilters variables

https://gerrit.wikimedia.org/r/463317

gerritbot added a comment.Sep 27 2018, 5:13 PM

Change 463319 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[operations/mediawiki-config@master] Remove config for RCFilters variables being removed from Core

https://gerrit.wikimedia.org/r/463319

SBisson moved this task from In Progress to Code Review on the Growth-Team (Current Sprint) board.Sep 27 2018, 6:59 PM
gerritbot added a comment.Oct 1 2018, 10:57 PM

Change 463315 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Remove rcfilters beta features and related tours

https://gerrit.wikimedia.org/r/463315

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 1 2018, 11:00 PM
gerritbot added a comment.Oct 1 2018, 11:09 PM

Change 463317 merged by jenkins-bot:
[mediawiki/core@master] Remove temporary rcfilters variables

https://gerrit.wikimedia.org/r/463317

gerritbot added a comment.Oct 2 2018, 12:36 AM

Change 463876 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] Remove unused function: isStructuredFilterUiEnabledByDefault

https://gerrit.wikimedia.org/r/463876

Catrope moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Oct 3 2018, 5:46 PM
gerritbot added a comment.Oct 3 2018, 6:01 PM

Change 463876 merged by jenkins-bot:
[mediawiki/core@master] Remove unused function: isStructuredFilterUiEnabledByDefault

https://gerrit.wikimedia.org/r/463876

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 3 2018, 7:00 PM
gerritbot added a comment.Oct 11 2018, 6:18 PM

Change 463319 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove config for RCFilters variables being removed from Core

https://gerrit.wikimedia.org/r/463319

SBisson added a comment.Oct 11 2018, 6:26 PM

The last part (cleaning up the variables in wmf-config) was just deployed.

Etonkovidova closed this task as Resolved.Oct 12 2018, 12:37 AM
SBisson closed subtask T195029: Retire $wgStructuredChangeFiltersShowPreference as Resolved.Oct 12 2018, 6:54 PM
gerritbot added a comment.May 8 2019, 8:36 PM

Change 508930 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Remove rcenhancedfilters from $wgDefaultUserOptions

https://gerrit.wikimedia.org/r/508930

gerritbot added a comment.May 8 2019, 8:37 PM

Change 508931 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/ORES@master] Remove all reference to rcenhancedfilters

https://gerrit.wikimedia.org/r/508931

gerritbot added a comment.May 8 2019, 8:38 PM

Change 508932 had a related patch set uploaded (by Catrope; owner: Catrope):
[operations/mediawiki-config@master] Remove rcenhancedfilters from beta features whitelist

https://gerrit.wikimedia.org/r/508932

gerritbot added a comment.May 8 2019, 8:53 PM

Change 508932 abandoned by Jforrester:
Remove rcenhancedfilters from beta features whitelist

Reason:
Let's do this in Iea7b2fc9 instead.

https://gerrit.wikimedia.org/r/508932

gerritbot added a comment.May 8 2019, 9:12 PM

Change 508930 merged by jenkins-bot:
[mediawiki/core@master] Remove rcenhancedfilters from $wgDefaultUserOptions

https://gerrit.wikimedia.org/r/508930

gerritbot added a comment.May 8 2019, 9:12 PM

Change 508931 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Remove all references to rcenhancedfilters

https://gerrit.wikimedia.org/r/508931

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 8 2019, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL