Page MenuHomePhabricator
Create Task
Maniphest T196051

CX2: Show reset option in the MT card only when the paragraph has been modified
Closed, ResolvedPublic
Actions

Description

The Automatic translation card (T188247) allows to select between MT services. Users can modify the proposed translation, and an option to "reset the translation" is provided to get the initial translation from the service again.

The "reset translation" option is only useful when the user has made modifications to the initial translation. Currently it is always shown. We want it to be only visible after the user made changes to the initial translation provided by the service.

mt-cad-simplified.png (811×1 px, 131 KB)

(Note that the above image uses labels that will be updated in T209606 and it is only intended to illustrate when the "Reset translation" option is expected to be shown and when it is not)

Details

SubjectRepoBranchLines +/-
Show reset option in the MT card only when section has been modifiedmediawiki/extensions/ContentTranslationmaster+118 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF triaged this task as Medium priority.May 31 2018, 9:32 AM
Pginer-WMF created this task.
Pginer-WMF mentioned this in T188247: CX2: Automatic Translation card to adjust MT options.May 31 2018, 11:44 AM
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Apr-June board.Jun 12 2018, 6:47 AM
Pginer-WMF merged a task: T195811: CX2: "Reset translation" option in MT card should not be shown all the time.Jun 27 2018, 11:04 AM
• Vvjjkkii renamed this task from CX2: Show reset option in the MT card only when the paragraph has been modified to gxbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from gxbaaaaaaa to CX2: Show reset option in the MT card only when the paragraph has been modified.Jul 2 2018, 2:10 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Pginer-WMF edited projects, added Language-2018-July-September; removed Language-2018-Apr-June.Jul 6 2018, 9:57 AM
Pginer-WMF edited projects, added Language-2018-Oct-December; removed Language-2018-July-September.Sep 3 2018, 11:27 AM
Arrbee edited projects, added Language-Team (Language-2018-October-December); removed Language-2018-Oct-December.Oct 4 2018, 4:53 PM
Pginer-WMF mentioned this in T209606: CX2: Adjust translation card to work better regardless of translation service availability.Nov 15 2018, 5:22 PM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2018-October-December) board.Nov 26 2018, 10:46 AM
Pginer-WMF updated the task description. (Show Details)Nov 28 2018, 8:52 AM
• santhosh claimed this task.Dec 10 2018, 6:32 AM
• santhosh moved this task from Priority backlog to In Progress on the Language-Team (Language-2018-October-December) board.
gerritbot subscribed.Dec 10 2018, 6:37 AM

Change 478584 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Show reset option in the MT card only when section has been modified

https://gerrit.wikimedia.org/r/478584

gerritbot added a project: Patch-For-Review.Dec 10 2018, 6:37 AM
• santhosh moved this task from In Progress to In Review on the Language-Team (Language-2018-October-December) board.Dec 10 2018, 6:37 AM
Pginer-WMF edited projects, added Language-Team (Language-2019-January-March); removed Language-Team (Language-2018-October-December).Dec 27 2018, 8:36 AM
Pginer-WMF moved this task from Backlog to In Review on the Language-Team (Language-2019-January-March) board.
Nikerabbit claimed this task.Jan 17 2019, 8:11 AM
Nikerabbit moved this task from In Review to In Progress on the Language-Team (Language-2019-January-March) board.
Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2019-January-March) board.Jan 22 2019, 8:00 AM
Nikerabbit added a comment.Mar 6 2019, 8:17 AM

There is a few known issues noted in the patch where "Reset section" appears when it shouldn't (but never not appearing when it should, to my knowledge). Solving those issues is not trivial (I was not able to figure out a solution), and they should be done separately. Question is: can the patch be merged with the known issues or whether the known issues must be fixed first?

Pginer-WMF added a comment.Mar 6 2019, 8:23 AM
In T196051#5003983, @Nikerabbit wrote:

There is a few known issues noted in the patch where "Reset section" appears when it shouldn't (but never not appearing when it should, to my knowledge). Solving those issues is not trivial (I was not able to figure out a solution), and they should be done separately. Question is: can the patch be merged with the known issues or whether the known issues must be fixed first?

I think it is ok to iterate in this case, and observe how frequent those cases are. so I think we can merge it.
As you mentioned, the most important thing is that we are not hiding the feature by mistake when the user may need it.

gerritbot added a comment.Mar 18 2019, 9:47 PM

Change 478584 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Show reset option in the MT card only when section has been modified

https://gerrit.wikimedia.org/r/478584

• Petar.petkovic removed a project: Patch-For-Review.Mar 18 2019, 9:53 PM
• Petar.petkovic moved this task from In Review to Needs QA-before deployment on the Language-Team (Language-2019-January-March) board.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 18 2019, 10:01 PM
Pginer-WMF edited projects, added Language-Team (Language-2019-April-June); removed Language-Team (Language-2019-January-March).Mar 29 2019, 9:32 PM
Pginer-WMF moved this task from Backlog to Needs QA on the Language-Team (Language-2019-April-June) board.
Etonkovidova closed this task as Resolved.Apr 9 2019, 9:43 PM
Etonkovidova mentioned this in T220559: "Reset translation" option issues.
Etonkovidova moved this task from Needs QA to Done on the Language-Team (Language-2019-April-June) board.
Etonkovidova subscribed.

Checked in testwiki (wmf.24) - 'Reset' option appears only when the content of the translated paragraph is modified.

The two known issues mentioned by @santhosh in https://gerrit.wikimedia.org/r/478584 were separated into a follow-up phab task T220559: "Reset translation" option issues

Pginer-WMF mentioned this in T168275: Automatic translation card showing unnecessary options initially.Jul 22 2019, 3:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL