Page MenuHomePhabricator

Wikidata primary sources tool deployment review
Open, Stalled, Needs TriagePublic

Event Timeline

Hjfocs created this task.May 31 2018, 2:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2018, 2:00 PM
Vvjjkkii renamed this task from Wikidata primary sources tool deployment review to uwbaaaaaaa.Jul 1 2018, 1:06 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptJul 1 2018, 1:06 AM
CommunityTechBot renamed this task from uwbaaaaaaa to Wikidata primary sources tool deployment review.Jul 2 2018, 3:02 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot edited subscribers, added: Aklapper; removed: Dereckson.
MaxSem changed the task status from Open to Stalled.Dec 14 2018, 7:01 AM
MaxSem added a subscriber: MaxSem.

For starters, this extension's code should be in Wikimedia source control.

Hjfocs updated the task description. (Show Details)Dec 14 2018, 11:20 AM

For starters, this extension's code should be in Wikimedia source control.

Could you please clarify?
It seems to me the code is in Wikimedia source control: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/PrimarySources

Aha, the code is still in a pull request. I've left some comments, but basically this code needs more work. Is the Wikidata team aware of this project?

I'm aware that it's coming, yes. We do want the Primary Sources Tool to be improved so are very thankful for @Hjfocs's work on it. We have not looked at the code.

@MaxSem , thanks a lot for your review! This was my first experience writing a MediaWiki extension, so I must have done a bunch of obvious mistakes. :-)

I wasn't expecting some months of latency after I opened this review request, and right now I'm fully devoted to the development of another Wikimedia project.
It would be ideal for me to focus on this extension after the completion of the current project.
Of course, let me know if there are any priority needs, I'll try my best to address them.

Nobody reviewed it because you just made a pull request to an obscure repository that nobody knows about and didn't ask anybody to review it or even reference it on Phabricator.

Hi @MaxSem,

Nobody reviewed it because you just made a pull request to an obscure repository that nobody knows about

I'm afraid I don't understand your point of view for the following reasons:

  1. the code is part of a Wikimedia IEG project: https://meta.wikimedia.org/wiki/Grants:IEG/StrepHit:_Wikidata_Statements_Validation_via_References/Renewal;
  2. the repository is located under the Wikidata organization umbrella on GitHub: https://github.com/Wikidata/;
  3. it is in the master branch: https://github.com/Wikidata/primarysources/tree/master.

and didn't ask anybody to review it

I totally disagree, because I tried my best to follow the official procedure to get into the review queue: https://www.mediawiki.org/wiki/Review_queue

or even reference it on Phabricator.

That's not true:

  1. the project has a dedicated Phabricator tag: Wikidata-primary-sources;
  2. this task is referenced with relevant Phabricator tags: Wikidata, Wikimedia-extension-review-queue, Wikimedia-Extension-setup.

Frankly, I'm not aware of any other steps I should have taken.