Page MenuHomePhabricator
Create Task
Maniphest T196084

[BlueSpiceFoundation] onMakeGlobalVariablesScript calls deprecated BsConfig::loadSettings
Closed, ResolvedPublic
Actions

Description

With BlueSpiceFoundation and ExtJSBase, hitting /index.php?title=Special:JavaScriptTest/qunit/export yields:

PHP Deprecated:  Use of BsConfig::loadSettings was deprecated in MediaWiki 3.0.0.
[Called from BsCore::doInitialise in extensions/BlueSpiceFoundation/includes/Core.class.php at line 288] in /workspace/src/includes/debug/MWDebug.php on line 309
PHP Deprecated:  Use of BsConfig::getScriptSettings was deprecated in MediaWiki 3.0.0.
[Called from BsCoreHooks::onMakeGlobalVariablesScript in BlueSpiceFoundation/includes/CoreHooks.php at line 197] in /workspace/src/includes/debug/MWDebug.php on line 309
FunctionDeprecated
BsCore::doInitialiseBsConfig::loadSettings
BsCoreHooks::onMakeGlobalVariablesScriptBsConfig::getScriptSettings

At first wfDeprecated() is for MediaWiki and there is no version 3.0.0 yet :] Regardless the callee should be updated in BsCoreHooks::onMakeGlobalVariablesScript.

Details

SubjectRepoBranchLines +/-
Change depecation warnings due to CI test issuesmediawiki/extensions/BlueSpiceFoundationmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.May 31 2018, 4:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2018, 4:53 PM
hashar updated the task description. (Show Details)Jun 1 2018, 3:33 PM
hashar added a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 1 2018, 4:03 PM
hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
hashar mentioned this in T130811: Enable unit tests on BlueSpice* repos.Jun 1 2018, 5:13 PM
hashar added a parent task: T130811: Enable unit tests on BlueSpice* repos.
Mglaser subscribed.Jun 1 2018, 8:21 PM

The version number refers to the upcoming BlueSpice version. AFAIC, wfDeprecated unfortunately only takes version numbers. Is there a better way to deprecated methods in versioned extensions?

Regardless, we will update the code.

Osnard subscribed.Jun 4 2018, 6:27 AM
hashar updated the task description. (Show Details)Jun 4 2018, 8:44 PM
Osnard claimed this task.Jun 6 2018, 5:53 AM

I will remove calls to deprecated interfaces asap.

hashar added a comment.Jun 6 2018, 4:51 PM

Thanks @Osnard.

hashar added a comment.Jun 18 2018, 3:06 PM

Any chance to have the deprecation notice to be either removed or fixed? :]

gerritbot subscribed.Jun 20 2018, 12:21 PM

Change 441198 had a related patch set uploaded (by Robert Vogel; owner: Robert Vogel):
[mediawiki/extensions/BlueSpiceFoundation@master] Change depecation warnings due to CI test issues

https://gerrit.wikimedia.org/r/441198

gerritbot added a project: Patch-For-Review.Jun 20 2018, 12:21 PM
Osnard added a comment.Jun 20 2018, 12:23 PM

I've removed the calls to wfDeprecated() in the places mentioned. Other occurrences will be fixed later. Sorry for the delay.

gerritbot added a comment.Jun 20 2018, 12:45 PM

Change 441198 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Change depecation warnings due to CI test issues

https://gerrit.wikimedia.org/r/441198

Aklapper added a project: Technical-Debt.Jun 20 2018, 12:47 PM
hashar added a comment.EditedJun 21 2018, 12:25 PM

The job now passes on master with php7.0 / mysql. Progress! Thank you @Osnard :]

I guess we can now mark this task resolved, I have filled it solely for the CI use case.

Osnard closed this task as Resolved.Jun 21 2018, 2:00 PM
hashar mentioned this in T197869: Deprecated call in BlueSpice extensions.Jun 21 2018, 2:16 PM
• Vvjjkkii renamed this task from [BlueSpiceFoundation] onMakeGlobalVariablesScript calls deprecated BsConfig::loadSettings to jwbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Osnard as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from jwbaaaaaaa to [BlueSpiceFoundation] onMakeGlobalVariablesScript calls deprecated BsConfig::loadSettings.Jul 2 2018, 2:58 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Osnard.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL