Page MenuHomePhabricator
Create Task
Maniphest T196104

Plain JavaScript code in unsighted box above the page
Closed, ResolvedPublic
Actions

Description

Since the last deployment some minutes ago plain JavaScript code is shown in the unsighted box above the page.

Seems be to be with German interface only. With &uselang=en it looks OK

Probably related to https://gerrit.wikimedia.org/r/#/c/309057/14/i18n/revisionreview/en.json

grafik.png (290×1 px, 23 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix compat with old local overrides for 'revreview-sadv-reviewing-c', 'revreview-sadv-reviewing-p'mediawiki/extensions/FlaggedRevsmaster+32 -7
Customize query in gerrit

Related Objects

Event Timeline

Raymond created this task.May 31 2018, 7:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2018, 7:58 PM
Raymond added a subscriber: matmarex.May 31 2018, 8:01 PM
Raymond updated the task description. (Show Details)May 31 2018, 8:03 PM
Raymond updated the task description. (Show Details)May 31 2018, 8:05 PM
Raymond added a comment.May 31 2018, 8:31 PM

For dewiki fixed with https://de.wikipedia.org/w/index.php?title=MediaWiki:Revreview-sadv-reviewing-c&diff=177920158&oldid=100352641&diffmode=source and https://de.wikipedia.org/w/index.php?title=MediaWiki:Revreview-sadv-reviewing-p&diff=prev&oldid=177920185&diffmode=source

But other wikis (WMF and 3rd party) that have these messages localized needs a fix too.

Aklapper mentioned this in T196109: Error in localized de-at translation for function advertiseReviewing.Jun 1 2018, 10:44 AM
• Vvjjkkii renamed this task from Plain JavaScript code in unsighted box above the page to zvbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from zvbaaaaaaa to Plain JavaScript code in unsighted box above the page.Jul 2 2018, 2:40 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
gerritbot subscribed.Jul 2 2018, 8:16 PM

Change 443503 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/FlaggedRevs@master] Fix compat with old local overrides for 'revreview-sadv-reviewing-c', 'revreview-sadv-reviewing-p'

https://gerrit.wikimedia.org/r/443503

gerritbot added a project: Patch-For-Review.Jul 2 2018, 8:16 PM
matmarex claimed this task.Jul 2 2018, 8:17 PM
matmarex triaged this task as Low priority.
gerritbot added a comment.Jul 17 2018, 1:11 AM

Change 443503 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Fix compat with old local overrides for 'revreview-sadv-reviewing-c', 'revreview-sadv-reviewing-p'

https://gerrit.wikimedia.org/r/443503

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 17 2018, 2:00 AM
matmarex closed this task as Resolved.Jul 17 2018, 11:53 PM
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits