Page MenuHomePhabricator
Create Task
Maniphest T196125

php-memcached 3.0 (PHP 7) incompatible with BagOStuff
Closed, ResolvedPublic
Actions

Description

@aaron noticed that the php-memcached extension has various breaking changes in the release for PHP 7.

https://packages.debian.org/jessie/php5-memcached

php5-memcached (2.2.0-2)

https://packages.debian.org/stretch/php-memcached

php-memcached (3.0.1

https://pecl.php.net/package/memcached/3.0.0

API:

  • The method signature of get, getByKey, getMulti, and getMultiByKey changed.
  • get* and getMulti* commands no longer take cas or user flags parameters.
  • get* and getMulti* commands now take the Memcached::GET_EXTENDED flag to retrieve user flags and cas tokens.

Session handler

  • The default protocol was changed from text to binary protocol. If your memcached setup does not support the binary protocol (e.g. if using twemproxy), then set memcached.sess_binary_protocol = Off. (Previously called memcached.sess_binary)

Details

SubjectRepoBranchLines +/-
objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0mediawiki/coreREL1_31+18 -5
objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0mediawiki/coreREL1_29+20 -5
objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0mediawiki/coreREL1_30+20 -5
objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0mediawiki/coreREL1_27+20 -5
objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0mediawiki/coremaster+17 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT176370 Migrate to PHP 7 in WMF production
 ResolvedaaronT196125 php-memcached 3.0 (PHP 7) incompatible with BagOStuff

Event Timeline

Krinkle triaged this task as Medium priority.Jun 1 2018, 1:10 AM
Krinkle created this task.
gerritbot subscribed.Jun 1 2018, 1:11 AM

Change 436683 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/436683

gerritbot added a project: Patch-For-Review.Jun 1 2018, 1:11 AM
ArielGlenn mentioned this in T196303: High rate of "Memcached error .. CONNECTION FAILURE" on snapshot hosts.Jun 4 2018, 8:51 AM
aaron claimed this task.Jun 4 2018, 7:57 PM
aaron moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.
CCicalese_WMF moved this task from Inbox to Watching on the MediaWiki-Platform-Team-Archived board.Jun 5 2018, 1:25 AM
gerritbot added a comment.Jun 5 2018, 3:50 PM

Change 436683 merged by jenkins-bot:
[mediawiki/core@master] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/436683

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 5 2018, 4:00 PM
gerritbot added a comment.Jun 5 2018, 8:38 PM

Change 437617 had a related patch set uploaded (by Reedy; owner: Aaron Schulz):
[mediawiki/core@REL1_31] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/437617

gerritbot added a comment.Jun 5 2018, 8:39 PM

Change 437618 had a related patch set uploaded (by Reedy; owner: Aaron Schulz):
[mediawiki/core@REL1_30] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/437618

gerritbot added a comment.Jun 5 2018, 8:41 PM

Change 437619 had a related patch set uploaded (by Reedy; owner: Aaron Schulz):
[mediawiki/core@REL1_29] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/437619

gerritbot added a comment.Jun 5 2018, 8:45 PM

Change 437621 had a related patch set uploaded (by Reedy; owner: Aaron Schulz):
[mediawiki/core@REL1_27] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/437621

Reedy mentioned this in T152345: Maximum execution time exceeded from Memcached (on page views).Jun 6 2018, 12:27 AM
Reedy merged a task: T152345: Maximum execution time exceeded from Memcached (on page views).
Reedy added subscribers: Reedy, Paladox.
Reedy added a project: MW-1.31-release.Jun 6 2018, 2:59 AM
Reedy moved this task from Backlog to Core on the MW-1.31-release board.
gerritbot added a comment.Jun 6 2018, 5:58 PM

Change 437621 merged by jenkins-bot:
[mediawiki/core@REL1_27] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/437621

ReleaseTaggerBot added a project: MW-1.27-release-notes.Jun 6 2018, 6:00 PM
gerritbot added a comment.Jun 6 2018, 6:02 PM

Change 437619 merged by jenkins-bot:
[mediawiki/core@REL1_29] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/437619

gerritbot added a comment.Jun 6 2018, 6:02 PM

Change 437618 merged by jenkins-bot:
[mediawiki/core@REL1_30] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/437618

gerritbot added a comment.Jun 6 2018, 6:02 PM

Change 437617 merged by jenkins-bot:
[mediawiki/core@REL1_31] objectcache: update MemcachedPeclBagOStuff for pecl memcached 3.0.0

https://gerrit.wikimedia.org/r/437617

Reedy closed this task as Resolved.Jun 6 2018, 6:19 PM
Reedy removed a project: Patch-For-Review.
ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.31-release-notes, MW-1.30-release-notes.Jun 6 2018, 7:00 PM
• Vvjjkkii renamed this task from php-memcached 3.0 (PHP 7) incompatible with BagOStuff to evbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed aaron as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Joe renamed this task from evbaaaaaaa to php-memcached 3.0 (PHP 7) incompatible with BagOStuff.Jul 1 2018, 5:51 AM
Joe assigned this task to aaron.
Joe lowered the priority of this task from High to Medium.
Joe removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Joe updated the task description. (Show Details)
aaron closed this task as Resolved.Jul 2 2018, 11:10 AM
CCicalese_WMF moved this task from Watching to Closed on the MediaWiki-Platform-Team-Archived board.Jul 12 2018, 12:45 AM
Reedy mentioned this in T150110: Creating new page with ShortUrl enabled results in array to string conversion.Sep 12 2018, 12:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL