Maniphest T196150

Regression: Links containing "action" always show the editor on mobile version regardless of value
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

At itwiki village pump it was pointed out that mobile version has some troubles with links containing the "action" parameters. Let's take as example the village pump page itself (mobile version). If you manually go to https://it.m.wikipedia.org/wiki/Wikipedia:Officina?action=edit, the usual editor pops up for a second and is then overlapped by a new editor which only contains the header of the page (everything that comes before the first section). Or, if you go to https://it.m.wikipedia.org/wiki/Wikipedia:Officina?action=purge, the window for purging the page is shown for a second and then the same partial editor comes out. This makes "action" completely unuseful for mobile users.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Drop issues on editor	mediawiki/skins/MinervaNeue	master	+3 -9
	Fix action!=edit opening the editor	mediawiki/skins/MinervaNeue	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T197834: Regression: Editing workflow broken for non-JS users and template editors on mobile
Mentioned Here: T196915: Give mobile editor a way to edit more than just a single section at once
T185729: &veaction=edit URL parameter does not work on mobile site

Event Timeline

Daimona created this task.Jun 1 2018, 10:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2018, 10:20 AM

• Jhernandez added a project: Web-Team-Backlog-Archived.Jun 4 2018, 10:49 AM

• Jhernandez moved this task from Needs triage to Triaged on the Mobile board.Jun 4 2018, 10:51 AM

This seems like a regression. This used to work fine.
Not sure if editing code outside MobileFrontend is causing this so tagging VisualEditor until we know the root cause

Yeah, VE is quite likely involved in this bug. I also tried to test this bug on my local wiki, but I actually surrendered due to Parsoid requirement for VE. Anyway, with MF alone it seems to work fine.

@DLynch I'm not sure 100% sure, but T185729 (I2275b011d2b3c03462e3c1711d3135ce672596e8) looks a little suspect

Jdlrobson renamed this task from Links containing "action=xxx" always show the editor on mobile version to Regression: Links containing "action" always show the editor on mobile version regardless of value.Jun 4 2018, 2:48 PM

ovasileva triaged this task as Medium priority.Jun 4 2018, 2:53 PM

DLynch claimed this task.Jun 4 2018, 3:18 PM

Change 437271 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/skins/MinervaNeue@master] Fix action!=edit opening the editor

https://gerrit.wikimedia.org/r/437271

gerritbot added a project: Patch-For-Review.Jun 4 2018, 3:20 PM

Change 437271 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix action!=edit opening the editor

https://gerrit.wikimedia.org/r/437271

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jun 4 2018, 3:57 PM

matmarex removed a project: Patch-For-Review.

matmarex moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.

Jdlrobson edited projects, added Web-Team-Backlog-Archived (Tracking); removed Web-Team-Backlog-Archived.Jun 4 2018, 3:59 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 4 2018, 4:00 PM

Fixed on beta cluster. However, I see that for action=edit the same things happen. Is this an intended behaviour? If the user goes to an "action=edit" link, wouldn't he expect to be editing the whole page instead of the first section?

@Daimona: I'm not opposed here, but the MobileFrontend currently only does section-editing. The mimic'd behavior here is as-if you had visited the page and then clicked the edit button at the very top of the page. (I think this is quite confusing even without this action=edit behavior, naturally.)

@DLynch thanks, got it :-) We'll wait for a major change to MF, then

"action=edit" allowed to edit a complete page. Why now not? It's a huge limit for the MobileFrontend.

This issue is fixed. Any requests about changing the behaviour of MobileFrontend's handling of section editing should go in a different task.

In T196150#4265991, @Ignazio wrote:

"action=edit" allowed to edit a complete page. Why now not? It's a huge limit for the MobileFrontend.

@Deskana i agree with this. This used to be the case yo make the editor resilient to js errors/power editors but the change from @DLynch seems to have disabled it. Conmit message says "Make ?veaction=edit/editsource and ?action=edit trigger the appropriate mobile
editing mode." Could you explain the reasoning behind this change? I often use the fallback for certain power editor task. The mobile editor and fallback editor should not be interchangeable in the same way as visual editor is
.

Whoops didnt mean to reopen it but i do think that @Ignazio needs a a reply!

I've made T196915 for the edit-a-full-page issue.

Jdforrester-WMF set the point value for this task to 1.Jun 13 2018, 6:26 PM

Jdlrobson mentioned this in T197834: Regression: Editing workflow broken for non-JS users and template editors on mobile.Jun 21 2018, 3:31 PM

• Vvjjkkii renamed this task from Regression: Links containing "action" always show the editor on mobile version regardless of value to pubaaaaaaa.Jul 1 2018, 1:06 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed DLynch as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value 1 for this task.

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

Daimona renamed this task from pubaaaaaaa to Regression: Links containing "action" always show the editor on mobile version regardless of value.Jul 1 2018, 12:29 PM

Daimona closed this task as Resolved.

Daimona assigned this task to DLynch.

Daimona lowered the priority of this task from High to Medium.