Page MenuHomePhabricator

HTML tweaks / Clean up ImagePage.php
Closed, ResolvedPublic

Description

Wrap "morelinkstoimage" within the div "mw-imagepage-section-linkstoimage" (diff to r47394)

Please clean up the imagePage.php to have proper HTML and no more FIXME/TODO in source.

I have make a few little change. My matter is to wrap "morelinkstoimage" within the div "mw-imagepage-section-linkstoimage", because it belongs to the other things in that div.

I cannot help by the TODO and FIXME.

I hope "user interface" is the right component.
Thank you.


Version: unspecified
Severity: enhancement
URL: http://commons.wikimedia.org/wiki/File:Heckert_GNU_white.svg

attachment ImagePage.php ignored as obsolete

Details

Reference
bz17617

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:35 PM
bzimport set Reference to bz17617.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 5849
a diff instead a new file of ImagePage.php

I have create a diff, instead of a new file with more little change then the first attachment.

attachment ImagePage.txt ignored as obsolete

Created attachment 5854
new Patch with more tweaks

My last try to make the HTML-Source more readable and add two divs. One for the metadata-section and one for the filehistory-section. Wrap "morelinkstoimage" into the existing div. Add ids "reupload-link" and "edit-external".

Feel free to change anything or make more. Thanks.

attachment ImagePage-patch.txt ignored as obsolete

demon added a comment.Mar 19 2009, 6:32 PM

Please resubmit without changing <tag attr=""> to <tag attr=''>. We generally use the former and changing these is useless.

Also, patch does not apply, I get a mis-smatched chunks error.

Created attachment 5967
new patch with using quots for atts

I hope the new patch is better and can used in the way you want used it.

I had not work with patch before.

attachment patch.txt ignored as obsolete

poke added a comment.Mar 27 2009, 6:45 PM

Sorry, but I don't like your patch. You don't need to use always the same quote-style. You can mix them and by that save a lot escapes, which makes the code a lot more readable.

Example (and that is completely fine):
$wgOut->addHTML( '<div id="shared-image-desc">' . $this->mExtraDescription . "</div>\n" );

demon added a comment.Mar 27 2009, 7:26 PM

Agree with Patrick. Also, I'm still getting the mis-matched chunks error. Are you diff'ing against trunk?

Created attachment 5973
new patch for HTML tweaks on ImagePage.php

I have download the php-Script from http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/ImagePage.php?revision=48951&view=markup&pathrev=48957

Open with [[WinMerge]], make the change and create a unified patch and attached them

I do not know it was a good idee but you can find the source on my sandbox under http://de.wikipedia.org/w/index.php?action=edit&oldid=58412452&uselang=en (diff: http://de.wikipedia.org/w/index.php?diff=58412452&oldid=58412402&uselang=en)

I hope you can work with that.

Attached:

demon added a comment.Mar 28 2009, 4:41 PM

Awesome. Done in r48967.