@MusikAnimal @Samwilson -- I just went through the current build on CommTech wiki and noted a set of issues, listed below, with gifs for some. These are in addition to the known issues that you sent to me:

• When I select certain combinations of checkbox filters in the New Page Patrol "Set filters" menu, they don't always stick and affect the list. In the gif below, I am trying to uncheck the "Unreviewed pages" option, but it won't stay unchecked.

• When I select "All" as the state for "Articles for Creation", nothing happens to the list. It shows some subset of the drafts. See gif below.

• For one of the drafts, the gray preview of the draft's content in the list differs from the actual content of the draft. In the gif below, the preview says, "A declined draft." But when I open the page, the draft says, "This draft is being reviewed now."

• When a draft has conflicting categories on it, it's unclear which state the feed will put it in. For instance, this draft has both the declined and pending categories. The feed puts it in state "Awaiting review" but not also in state "Declined". Though this edge case should not occur, it is possible. My preferred business logic is that the feed lists it in both states. What are our constraints here?
• We should remove the "Category" and "Orphan" metadata listed next to each draft, since those are not relevant.

Thanks for the thorough testing!

When I select certain combinations of checkbox filters in the New Page Patrol "Set filters" menu, they don't always stick and affect the list. In the gif below, I am trying to uncheck the "Unreviewed pages" option, but it won't stay unchecked.

Confirmed regression :(

When I select "All" as the state for "Articles for Creation", nothing happens to the list. It shows some subset of the drafts. See gif below.

I think this was due to data corruption after we changed the code. I can't repro now. Let me know if you can!

For one of the drafts, the gray preview of the draft's content in the list differs from the actual content of the draft. In the gif below, the preview says, "A declined draft." But when I open the page, the draft says, "This draft is being reviewed now."

Confirmed. The snippet for drafts are not updated, but they are for mainspace pages. Baffling!

When a draft has conflicting categories on it, it's unclear which state the feed will put it in. For instance, this draft has both the declined and pending categories. The feed puts it in state "Awaiting review" but not also in state "Declined". Though this edge case should not occur, it is possible. My preferred business logic is that the feed lists it in both states. What are our constraints here?

Only one value can be stored for the state, so we go in order: 1) Unsubmitted 2) Pending 3) Under review 4) Declined. Whichever one it finds first, in that order, is the state that gets assigned. One would have to manually add the second category for this to happen in production, or (maybe) add a second template. Both scenarios should be very rare. The reviewers will have to fix it.

We should remove the "Category" and "Orphan" metadata listed next to each draft, since those are not relevant.

Done!

All of the above bugs should now be fixed! :)

There is one oddity -- sometimes when switching from AfC to NPP, your old NPP filters are forgotten. I don't think this is a huge deal, but I'll still try to fix it.

@MusikAnimal @Samwilson -- I retested everything, and I confirm that all the bugs I listed are fixed. I have one new one:

The "total unreviewed pages" number at the bottom of the feed isn't right. The two screenshots below show it disagreeing with the list for both NPP and AfC settings.

This seems to be because of the caching. The 'unreviewed' stats at the bottom there are cached for 10 minutes (and nothing refreshes the cache when an item is updated, I guess by design?).

We have CACHE_NONE in /vagrant/mediawiki/LocalSettings.php, but I wonder if there's another part of the Vagrant config that's turning the cache on? (Sorry, I'm not completely familiar with how things are set up there.)

Anyway, I can't see anything else that could be doing this, and the numbers are all correct in my testing (on local, and on commtech after waiting ten minutes).

@MMiller_WMF Should this ticket now be transferred to the Growth team board?

In T196177#4489921, @Niharika wrote:

@MMiller_WMF Should this ticket now be transferred to the Growth team board?

I'll be bold and move it.

Thanks, @Niharika -- I'm sorry I missed this.

No problem!