Page MenuHomePhabricator
Create Task
Maniphest T196208

Provide localized Bold and Italic icons for Urdu
Closed, ResolvedPublic
Actions

Description

hi,

Change following things:

  1. A (Bold) => ج
  2. A (Italic) = > ت

IMG_20180602_062112.jpg (162×960 px, 25 KB)

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.30.0mediawiki/coremaster+266 -98
icons: Add localized 'bold' and 'italic' for Urduoojs/uimaster+22 -4
Customize query in gerrit

Event Timeline

BukhariSaeed created this task.Jun 2 2018, 1:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2018, 1:21 AM
BukhariSaeed renamed this task from Change Bold and Italic icons on Urdu Wikipedia to Change Bold and Italic icons on All Urdu Wiki Projects.Jun 2 2018, 1:30 AM
Aklapper added a project: WikiEditor.Jun 2 2018, 11:47 AM

@BukhariSaeed: For future reference, please follow https://www.mediawiki.org/wiki/How_to_report_a_bug and always provide steps to reproduce.

If I interpret the image correctly, this might be about WikiEditor.

Aklapper renamed this task from Change Bold and Italic icons on All Urdu Wiki Projects to Provide localized Bold and Italic icons for Urdu.Jun 2 2018, 11:48 AM
Aklapper added a project: OOUI.

@BukhariSaeed: If you would like to work on this, see https://gerrit.wikimedia.org/r/#/c/435819/ for an example how to add a localized button as an SVG file, and see https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to write software changes. Thanks!

MuhammadShuaib added a comment.Jun 3 2018, 2:41 PM

If someone provides SVGs of desired icons then I proceed to patch.

Volker_E triaged this task as Medium priority.Jun 4 2018, 4:02 PM
• Vvjjkkii renamed this task from Provide localized Bold and Italic icons for Urdu to 3sbaaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 3sbaaaaaaa to Provide localized Bold and Italic icons for Urdu.Jul 2 2018, 1:43 PM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
BukhariSaeed added a comment.Dec 15 2018, 8:10 AM
In T196208#4252075, @MuhammadShuaib wrote:

If someone provides SVGs of desired icons then I proceed to patch.

I think no one is available :(

Ammarpad subscribed.Dec 15 2018, 8:40 AM
Ammarpad added a comment.Dec 15 2018, 7:10 PM
In T196208#4252075, @MuhammadShuaib wrote:

If someone provides SVGs of desired icons then I proceed to patch.

Tulsi_Bhagat claimed this task.Dec 17 2018, 4:23 AM
gerritbot subscribed.Dec 17 2018, 5:24 AM

Change 480000 had a related patch set uploaded (by Tulsi Bhagat; owner: Tulsi Bhagat):
[oojs/ui@master] Add localized 'bold' and 'italic' icons for Urdu

https://gerrit.wikimedia.org/r/480000

gerritbot added a project: Patch-For-Review.Dec 17 2018, 5:24 AM
gerritbot added a comment.Dec 17 2018, 4:47 PM

Change 480000 merged by jenkins-bot:
[oojs/ui@master] icons: Add localized 'bold' and 'italic' for Urdu

https://gerrit.wikimedia.org/r/480000

Jdforrester-WMF edited projects, added OOUI (OOUI-0.30.0); removed Patch-For-Review, OOUI.Dec 17 2018, 4:48 PM
Jdforrester-WMF added subscribers: Esanders, Jdforrester-WMF.

Thank you, @Tulsi_Bhagat and @Esanders. This will roll out in the next release of OOUI.

MuhammadShuaib added a comment.Dec 21 2018, 4:23 PM
In T196208#4828239, @Jdforrester-WMF wrote:

Thank you, @Tulsi_Bhagat and @Esanders. This will roll out in the next release of OOUI.

When will next release be expected?

gerritbot added a comment.Dec 22 2018, 11:37 AM

Change 481239 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

gerritbot added a project: Patch-For-Review.Dec 22 2018, 11:37 AM
Jdforrester-WMF added a comment.Dec 22 2018, 12:23 PM
In T196208#4840589, @MuhammadShuaib wrote:
In T196208#4828239, @Jdforrester-WMF wrote:

Thank you, @Tulsi_Bhagat and @Esanders. This will roll out in the next release of OOUI.

When will next release be expected?

The second week of January, if the above patch lands in time.

gerritbot added a comment.Dec 24 2018, 1:51 AM

Change 481239 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

Jdforrester-WMF closed this task as Resolved.Jan 1 2019, 4:05 PM
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed Patch-For-Review.
BukhariSaeed added a comment.EditedJan 1 2019, 8:01 PM

@Jdforrester-WMF No changes seen

Aklapper added a comment.Jan 1 2019, 8:39 PM

@BukhariSaeed: Please read T196208#4841890 and see the meaning of "Resolved". :)

BukhariSaeed added a comment.Jan 2 2019, 12:51 PM
In T196208#4847850, @Aklapper wrote:

@BukhariSaeed: Please read T196208#4841890 and see the meaning of "Resolved". :)

@Aklapper When the modifications will be visible?

MuhammadShuaib added a comment.Jan 2 2019, 1:04 PM
In T196208#4848817, @BukhariSaeed wrote:
In T196208#4847850, @Aklapper wrote:

@BukhariSaeed: Please read T196208#4841890 and see the meaning of "Resolved". :)

@Aklapper When the modifications will be visible?

It can takes upto 2 weeks, so be patient. :)

Aklapper added a comment.Jan 2 2019, 8:04 PM
In T196208#4848817, @BukhariSaeed wrote:

@Aklapper When the modifications will be visible?

I already linked to https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle which answers your question.

MuhammadShuaib added a comment.Jan 11 2019, 10:21 AM

Icons are now appeared on Urdu wikipedia but do not look attractive as their size is too small and umnecessary space between two icons looks very weird. Below is comparison between urwiki and fawiki icons:

In Urdu wiki:

IMG_20190111_154236.jpg (173×545 px, 18 KB)

And Farsi wiki:

IMG_20190111_154341.jpg (198×453 px, 15 KB)

Ammarpad added a comment.Jan 15 2019, 4:46 PM
In T196208#4872467, @MuhammadShuaib wrote:

Icons are now appeared on Urdu wikipedia but do not look attractive as their size is too small and umnecessary space between two icons looks very weird. Below is comparison between urwiki and fawiki icons:

In Urdu wiki:

IMG_20190111_154236.jpg (173×545 px, 18 KB)

And Farsi wiki:

IMG_20190111_154341.jpg (198×453 px, 15 KB)

They look OK to me. I don't see any unnecessary space either.

happy5214 moved this task from Backlog to Closed on the WikiEditor board.Aug 4 2019, 11:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL