Page MenuHomePhabricator
Create Task
Maniphest T196264

View a referenced Sense
Closed, ResolvedPublic
Actions

Description

Narrative:
As an editor of Wikidata-Lexeme I want to be able to view a referenced Sense in a statement on an Item/Property/Form/Sense/Lexeme in order to better understand what the statement is trying to say.

Acceptance Criteria:

  • The behaviour is the same no matter which of Item/Property/Form/Sense/Lexeme the statement is on
  • The shown value follows the pattern "Lemma (Gloss)" - for example: "move (to change position)"
  • The Gloss is shown in the user's interface language and the standard language fallback chain is applied. If no fallback can be found the ID of the Sense is shown. (Note: language fallbacks are subject of the separate task T200983: Language fallbacks for referenced Senses in statements and may be omitted from the initial implementation of this task.)

Given:
When:
Then:

Personas to take into account:
Niels - Active editor on Wikidata
Alex - Data user in small startup

Open questions:

  • If the lemma and the gloss are in languages with different directions, how should they be arranged?

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Render lemmas and gloss in SenseIdTextFormattermediawiki/extensions/WikibaseLexememaster+158 -5
Add SenseIdHtmlFormattermediawiki/extensions/WikibaseLexememaster+153 -0
Introduce SenseIdTextFormattermediawiki/extensions/WikibaseLexememaster+54 -26
Make wikibase-sense datatype use entity ID valuesmediawiki/extensions/WikibaseLexememaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• RazShuty created this task.Jun 3 2018, 9:43 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 3 2018, 9:43 AM
• RazShuty mentioned this in T196263: Reference a Sense in a statement .Jun 3 2018, 11:13 AM
• RazShuty added a project: Story.Jun 3 2018, 11:54 AM
• RazShuty updated the task description. (Show Details)
Lydia_Pintscher updated the task description. (Show Details)Jun 3 2018, 7:12 PM
WMDE-leszek added a comment.Jun 4 2018, 7:17 AM

Rare case clarification request regarding

The shown value follows the pattern "Lemma (Gloss)" - for example: "move (to change position)"

When there are multiple lemma variants, then all should be shown with the i18n-able separator etc, or just one (if so, please define the algorithm on how to pick _the_ one)?

Lydia_Pintscher subscribed.Jun 4 2018, 8:41 AM

Yeah. Like in other places when there are several Lemmas we show them all separated by the i18n-able separator.

• Vvjjkkii renamed this task from View a referenced Sense to jrbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
CommunityTechBot renamed this task from jrbaaaaaaa to View a referenced Sense.Jul 2 2018, 12:44 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Lydia_Pintscher added a parent task: T196263: Reference a Sense in a statement .Aug 2 2018, 8:44 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 7 2018, 11:15 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 7 2018, 11:21 AM
Lucas_Werkmeister_WMDE added a subscriber: Charlie_WMDE.
Lucas_Werkmeister_WMDE claimed this task.Aug 7 2018, 12:56 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Senses-Iteration2.
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Wikidata-Senses-Iteration2 board.
gerritbot subscribed.Aug 7 2018, 4:15 PM

Change 451015 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make wikibase-sense datatype use entity ID values

https://gerrit.wikimedia.org/r/451015

gerritbot added a project: Patch-For-Review.Aug 7 2018, 4:15 PM

Change 451016 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Introduce SenseIdTextFormatter

https://gerrit.wikimedia.org/r/451016

gerritbot added a comment.Aug 7 2018, 4:15 PM

Change 451017 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add SenseIdHtmlFormatter

https://gerrit.wikimedia.org/r/451017

Lucas_Werkmeister_WMDE mentioned this in rEWLE6a4cd3fe7712: Make wikibase-sense datatype use entity ID values.Aug 7 2018, 4:20 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEe6fe0e4fbf0d: Introduce SenseIdTextFormatter.
Lucas_Werkmeister_WMDE mentioned this in rEWLE80d157c460c9: Add SenseIdHtmlFormatter.
Lucas_Werkmeister_WMDE mentioned this in rEWLE42a40af9721a: Introduce SenseIdTextFormatter.Aug 7 2018, 4:34 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEc0e70ef57f19: Add SenseIdHtmlFormatter.
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration2 board.Aug 7 2018, 4:35 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
gerritbot added a comment.Aug 8 2018, 9:33 AM

Change 451264 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Render lemmas and gloss in SenseIdHtmlFormatter

https://gerrit.wikimedia.org/r/451264

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 8 2018, 9:34 AM
Lucas_Werkmeister_WMDE mentioned this in rEWLEac9e2be8dca2: Render lemmas and gloss in SenseIdHtmlFormatter.Aug 8 2018, 9:35 AM
gerritbot added a comment.Aug 8 2018, 9:51 AM

Change 451015 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make wikibase-sense datatype use entity ID values

https://gerrit.wikimedia.org/r/451015

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 8 2018, 10:00 AM
gerritbot added a comment.Aug 8 2018, 12:16 PM

Change 451016 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Introduce SenseIdTextFormatter

https://gerrit.wikimedia.org/r/451016

hoo updated the task description. (Show Details)Aug 9 2018, 9:42 AM
hoo mentioned this in rEWLE4b109eea6660: Add SenseIdHtmlFormatter.Aug 9 2018, 10:01 AM
hoo updated the task description. (Show Details)Aug 9 2018, 10:12 AM
hoo mentioned this in rEWLEe1f2b08fa38d: Add SenseIdHtmlFormatter.Aug 9 2018, 10:39 AM
gerritbot added a comment.Aug 9 2018, 1:51 PM

Change 451017 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add SenseIdHtmlFormatter

https://gerrit.wikimedia.org/r/451017

hoo moved this task from Peer Review to Doing on the Wikidata-Senses-Iteration2 board.Aug 9 2018, 1:52 PM
hoo subscribed.

This will need some more love.

Lucas_Werkmeister_WMDE mentioned this in rEWLEade925ec34fd: Render lemmas and gloss in SenseIdHtmlFormatter.Aug 13 2018, 1:31 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEbf6f045e0370: Render lemmas and gloss in SenseIdTextFormatter.Aug 13 2018, 1:34 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEba58dcae2e3d: Render lemmas and gloss in SenseIdTextFormatter.Aug 13 2018, 1:45 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE500c12f9b287: Render lemmas and gloss in SenseIdTextFormatter.Aug 13 2018, 2:15 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEef02f5aef37f: Render lemmas and gloss in SenseIdTextFormatter.Aug 13 2018, 2:27 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration2 board.Aug 13 2018, 2:35 PM

I’ve updated the change, and it’s not clear to me what else is required under “more love”, so moving back to review :)

Lucas_Werkmeister_WMDE mentioned this in rEWLE0e08a3e4d42c: Render lemmas and gloss in SenseIdTextFormatter.Aug 13 2018, 4:47 PM
WMDE-leszek added a project: Wikidata-Senses-Iteration3.Aug 14 2018, 11:39 AM
WMDE-leszek moved this task from To Do to Doing on the Wikidata-Senses-Iteration3 board.Aug 14 2018, 11:43 AM
WMDE-leszek moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration3 board.
gerritbot added a comment.Aug 14 2018, 3:32 PM

Change 451264 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Render lemmas and gloss in SenseIdTextFormatter

https://gerrit.wikimedia.org/r/451264

Ladsgroup moved this task from Peer Review to Test (Product Review) on the Wikidata-Senses-Iteration3 board.Aug 14 2018, 3:42 PM
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:54 PM
Liuxinyu970226 subscribed.Aug 14 2018, 10:24 PM
Lydia_Pintscher added a comment.Aug 20 2018, 8:27 AM

Léa and I just tried to save a statement linking to a Sense. We got an error :(

Screenshot_20180820_102508.png (616×1 px, 53 KB)

Lydia_Pintscher moved this task from Test (Product Review) to Doing on the Wikidata-Senses-Iteration3 board.Aug 20 2018, 8:28 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Test (Product Review) on the Wikidata-Senses-Iteration3 board.Aug 20 2018, 10:18 AM
Addshore subscribed.Aug 20 2018, 10:18 AM
In T196264#4513783, @Lydia_Pintscher wrote:

Léa and I just tried to save a statement linking to a Sense. We got an error :(

Screenshot_20180820_102508.png (616×1 px, 53 KB)

Need to clear the local storage of your browser D:

Lydia_Pintscher closed this task as Resolved.Aug 20 2018, 3:43 PM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.

\o/

Liuxinyu970226 unsubscribed.Aug 23 2018, 2:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL