Page MenuHomePhabricator

Select a Sense as value in statement
Closed, ResolvedPublic

Description

Narrative:
As an editor of Wikidata-Lexeme I want to be able to select a Sense as a value in statement in order to for example connect it with a Sense on another Lexeme to describe a translation.

Acceptance Criteria:

  • I can make statements with a Sense as a value no matter if I'm on Item, Property, Form, Sense or Lexeme
  • I can enter the ID of a Sense and it'll be accepted
  • I can not store an invalid Sense ID as a value
  • An edit summary is added to the edit history of the page when saving the statement with a Sense as a value

BDD:

GIVEN I select a property of data type Sense
WHEN I enter the Sense ID like L1-S2 in the value field
AND Click save
THEN The statement is persisted
AND The Sense ID is shown as a link (to be improved upon by T200983)
AND The link target is the section of the specified Sense on the Lexeme page
AND The edit summary is "Added new Sense L1-S1 with [en] Gloss: foo"

GIVEN I select a property of data type Sense
WHEN I enter a Sense ID like L1-S2 in the value field
AND L1-S2 does not exist
THEN the publish link is grayed out
AND a "no match was found" message is shown in the entity selector

Screenshots:
Failure case for selecting an invalid Form:

Patch-For-Review:

Event Timeline

CommunityTechBot renamed this task from erbaaaaaaa to Select a Sense as value in statement.Jul 2 2018, 12:41 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)

Change 452369 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add validators for sense data type

https://gerrit.wikimedia.org/r/452369

Change 452370 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add rudimentary search support for senses

https://gerrit.wikimedia.org/r/452370

Change 452371 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Set input to sense ID in Sense expert

https://gerrit.wikimedia.org/r/452371

Change 452369 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add validators for sense data type

https://gerrit.wikimedia.org/r/452369

Change 452370 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add rudimentary search support for senses

https://gerrit.wikimedia.org/r/452370

Change 452371 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Set input to sense ID in Sense expert

https://gerrit.wikimedia.org/r/452371