Page MenuHomePhabricator
Create Task
Maniphest T196436

EditSubpages extension fails mediawiki/core webdriver.io tests
Open, Needs TriagePublic
Actions

Description

The EditSubpages extension restricts anonymous users from editing most pages. As such as the webdriver.io spec tests in mediawiki/core fail due to a permission error. https://www.mediawiki.org/wiki/Extension:EditSubpages

User
     ✓ should be able to create account
     ✓ should be able to log in
     ✓ should be able to change preferences

1) Page should be creatable:
An element could not be located on the page using the given search parameters ("#wpTextbox1").

2) Page should be re-creatable:
An element could not be located on the page using the given search parameters ("#wpTextbox1").

3) Page should be editable:
invalid element state: Element must be user-editable in order to clear it.

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/5253/

Assuming the extensions tests are run first and that we have admin rights on the wiki, we should be able to whitelist a few pages to allow edition. The wiki page mentions whitelisting them in [[MediaWiki:Unlockedpages]].

See also T196960 which is to let some extensions opt out of running webdriver.io tests.

Related Objects
Search...

Event Timeline

hashar created this task.Jun 5 2018, 8:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2018, 8:48 AM
zeljkofilipin added a comment.Jun 5 2018, 10:19 AM

Assuming the extensions tests are run first and that we have admin rights on the wiki, we should be able to whitelist a few pages to allow edition.

I don't think that would work. By design, each test is a world for itself, with as little dependencies as possiblek, mediawiki with admin user are the only ones, I think. Each test creates things it needs (users, pages...) with random names. There is no way at the moment that a test could influence another test. Also, I think that should not be possible. Among other things, that leads to more robust tests that can be executed in any order or in parallel. A test depending on another test is a code smell.

• Vvjjkkii renamed this task from EditSubpages extension fails mediawiki/core webdriver.io tests to rmbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot updated the task description. (Show Details)Jul 1 2018, 9:32 PM
CommunityTechBot removed projects: TCB-Team, Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot renamed this task from rmbaaaaaaa to EditSubpages extension fails mediawiki/core webdriver.io tests.
CommunityTechBot added a subscriber: Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL