Maniphest T196436

EditSubpages extension fails mediawiki/core webdriver.io tests
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	hashar
	Jun 5 2018, 8:48 AM

Description

The EditSubpages extension restricts anonymous users from editing most pages. As such as the webdriver.io spec tests in mediawiki/core fail due to a permission error. https://www.mediawiki.org/wiki/Extension:EditSubpages

User
     ✓ should be able to create account
     ✓ should be able to log in
     ✓ should be able to change preferences

1) Page should be creatable:
An element could not be located on the page using the given search parameters ("#wpTextbox1").

2) Page should be re-creatable:
An element could not be located on the page using the given search parameters ("#wpTextbox1").

3) Page should be editable:
invalid element state: Element must be user-editable in order to clear it.

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/5253/

Assuming the extensions tests are run first and that we have admin rights on the wiki, we should be able to whitelist a few pages to allow edition. The wiki page mentions whitelisting them in [[MediaWiki:Unlockedpages]].

See also T196960 which is to let some extensions opt out of running webdriver.io tests.

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T190097 Migrate all CI jobs from Nodepool, deprecate its use
Resolved	hashar	T183512 [EPIC] Migrate Mediawiki jobs from Nodepool to Docker
Open	None	T196436 EditSubpages extension fails mediawiki/core webdriver.io tests

Event Timeline

hashar created this task.Jun 5 2018, 8:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2018, 8:48 AM

hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 5 2018, 8:48 AM

hashar added a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 5 2018, 9:21 AM

Assuming the extensions tests are run first and that we have admin rights on the wiki, we should be able to whitelist a few pages to allow edition.

I don't think that would work. By design, each test is a world for itself, with as little dependencies as possiblek, mediawiki with admin user are the only ones, I think. Each test creates things it needs (users, pages...) with random names. There is no way at the moment that a test could influence another test. Also, I think that should not be possible. Among other things, that leads to more robust tests that can be executed in any order or in parallel. A test depending on another test is a code smell.

zeljkofilipin awarded a token.Jun 5 2018, 10:19 AM

hashar mentioned this in T196960: Quibble should have a way for extensions to opt out of core selenium browser tests.Jun 14 2018, 9:44 AM

hashar updated the task description. (Show Details)

zeljkofilipin added projects: User-zeljkofilipin, MediaWiki-Core-Testing.Jun 14 2018, 9:46 AM

zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Testing board.

• Vvjjkkii renamed this task from EditSubpages extension fails mediawiki/core webdriver.io tests to rmbaaaaaaa.Jul 1 2018, 1:06 AM

• Vvjjkkii triaged this task as High priority.