Page MenuHomePhabricator

Prevent floats from intruding into edit area in previews if no toolbar present
Closed, ResolvedPublic

Description

Add br clear if the toolbar is not active.

In shared.css, #toolbar is given the style clear:both; to avoid floats intruding from the text area. (for example: an image that floats on the side, see this for an example how it should NOT be: [[:w:de:Image:Brclearmissing.png]]).
If the user turns off the toolbar in his preferences, or if he doesn't activate Javascript, this fails (see linked image above). The attached patch should fix this, as it gives out a <br clear="both"/> if the toolbar is not active.


Version: unspecified
Severity: normal

attachment EditPage.patch ignored as obsolete

Details

Reference
bz17648

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:31 PM
bzimport set Reference to bz17648.

Fixed link: [[:de:Image:Brclearmissing.png]]
(I think bugzilla needs a preview option as well :))

Comment on attachment 5859
Add br clear if the toolbar is not active.

typo

Please, do not clutter the code with unnecessary markup. Add "clear: both;" as a part of CSS style to the form instead. It will serve the same and the code will remain the same.

uses CSS instead of inserting HTML code

I'm Sorry. This should fix it.

Attached: