Page MenuHomePhabricator

Write a specification for mapping banner/landing page impression event properties -> database schema
Open, NormalPublic2 Story Points

Description

Let's set out exactly what goes where in the database from the banner impression and landing page impression Kafka streams, for clarity and maintainability.


See: draft specification and additional review notes.

Event Timeline

AndyRussG triaged this task as Normal priority.Jun 6 2018, 3:19 PM
AndyRussG created this task.
AndyRussG claimed this task.Jun 6 2018, 3:53 PM
AndyRussG added a subscriber: Ejegg.
Ejegg added a comment.Jun 22 2018, 6:52 PM

Added a comment on the talk page

Vvjjkkii renamed this task from Write a specification for mapping banner/landing page impression event properties -> database schema to 8ibaaaaaaa.Jul 1 2018, 1:06 AM
Vvjjkkii removed AndyRussG as the assignee of this task.
Vvjjkkii raised the priority of this task from Normal to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed the point value for this task.
Vvjjkkii removed subscribers: Aklapper, gerritbot.
CommunityTechBot renamed this task from 8ibaaaaaaa to Write a specification for mapping banner/landing page impression event properties -> database schema.Jul 2 2018, 8:10 AM
CommunityTechBot assigned this task to AndyRussG.
CommunityTechBot lowered the priority of this task from High to Normal.
CommunityTechBot set the point value for this task to 2.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: Aklapper, gerritbot.
Ejegg added a comment.Jul 5 2018, 9:31 PM

Reviewed the banner impression section, all seems to match the code. Looking at landing page stuff next.

Ejegg added a comment.Jul 6 2018, 12:23 AM

OK, the landing page specification looks good too. Just might want to note that the donatewiki tables are only inserted when the hostname is donate.wikimedia.org.

OK, will add that! :) thx!!!

AndyRussG updated the task description. (Show Details)May 27 2019, 8:50 PM

This looks +2able from my side. I'll just let Elliott confirm he's good with the donatewiki tables note!

Ejegg added a comment.Aug 7 2019, 3:08 PM

Yep, the note at the top of the 'Mapping from LandingPageImpression events' section looks like good clarification.

+2 !

Ejegg added a comment.Aug 7 2019, 3:14 PM

(Or rather, +2 as soon as it's moved out of draft namespace)