Page MenuHomePhabricator
Create Task
Maniphest T196611

TranslateYamlTest::testBug76309 seems to be flaky on HHVM
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

08:45:33 1) TranslateYamlTest::testBug76309
08:45:33 Floaty strings outputted as strings
08:45:33 Failed asserting that two strings are equal.
08:45:33 --- Expected
08:45:33 +++ Actual
08:45:33 @@ @@
08:45:33  '---
08:45:33 -a: "2."
08:45:33 -b: "22222222222222222222222222222222222222222222222222222222222222."
08:45:33 +a: ""2.""
08:45:33 +b: ""22222222222222222222222222222222222222222222222222222222222222.""
08:45:33  c: 2.000000
08:45:33  d: "2.0"
08:45:33  ...
08:45:33  '
08:45:33 
08:45:33 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Translate/tests/phpunit/TranslateYamlTest.php:68
08:45:33 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:423
08:45:33 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:94

I've seen this fail twice now in the past few days.

Details

SubjectRepoBranchLines +/-
TranslateYaml: Fix flaky failures in floaty fixmediawiki/extensions/Translatemaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Jun 7 2018, 8:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2018, 8:48 AM
Nikerabbit subscribed.Jun 7 2018, 8:52 AM

It shouldn't be flaky at all. Are you sure it's not failing always?

See T194656: Floats with no decimal digits exported incorrectly in Yaml format for context. If it is failing consistently, I can try to disable my code path for HHVM.

Legoktm added a comment.Jun 7 2018, 9:04 AM

If it were failing constantly, all MediaWiki core patches would be failing and others would have complained by now :P

https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/48554/console was the other failure I had seen on https://gerrit.wikimedia.org/r/#/c/437051/

Nikerabbit added a comment.Jun 7 2018, 9:10 AM

Does that mean that different versions of HHVM are being used to run tests? I can't imagine why else the test would be flaky.

Both failing and passing runs show Using HHVM 3.18.6-dev (5.6.99-hhvm).

Only other thing I can think about is shell locale...

Nikerabbit added a comment.Jun 7 2018, 9:13 AM

Oh crap... it also failed on PHP.... what on earth is going on with phpyaml?!

Or is it MWCryptRand::generateHex( 8 );... it can also create numbers only?

gerritbot subscribed.Jun 7 2018, 9:18 AM

Change 437931 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] TranslateYaml: Fix flaky failures in floaty fix

https://gerrit.wikimedia.org/r/437931

gerritbot added a project: Patch-For-Review.Jun 7 2018, 9:18 AM
gerritbot added a comment.Jun 7 2018, 9:45 AM

Change 437931 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] TranslateYaml: Fix flaky failures in floaty fix

https://gerrit.wikimedia.org/r/437931

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 7 2018, 10:00 AM
Nikerabbit edited projects, added User-Nikerabbit; removed Patch-For-Review.Jun 7 2018, 10:05 AM
Legoktm closed this task as Resolved.Jun 7 2018, 5:31 PM
Legoktm assigned this task to Nikerabbit.
In T196611#4263341, @Nikerabbit wrote:

Does that mean that different versions of HHVM are being used to run tests? I can't imagine why else the test would be flaky.

Both failing and passing runs show Using HHVM 3.18.6-dev (5.6.99-hhvm).

Only other thing I can think about is shell locale...

Same HHVM and shell locale versions should be used. I think your suspicion about generateHex() returning only numbers seems more likely, simply because that's the major area of variance in the test.

I'll re-open if I see this again.

Krinkle added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Jun 9 2018, 12:57 AM
• Vvjjkkii renamed this task from TranslateYamlTest::testBug76309 seems to be flaky on HHVM to whbaaaaaaa.Jul 1 2018, 1:05 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Nikerabbit as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Krinkle renamed this task from whbaaaaaaa to TranslateYamlTest::testBug76309 seems to be flaky on HHVM.Jul 1 2018, 11:38 PM
Krinkle closed this task as Resolved.
Krinkle assigned this task to Nikerabbit.
Krinkle raised the priority of this task from High to Needs Triage.
Krinkle removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Krinkle updated the task description. (Show Details)
Krinkle moved this task from Untriaged to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.
Krinkle added a subscriber: Aklapper.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Nikerabbit removed a project: User-Nikerabbit.Mar 25 2020, 12:15 PM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL