Description

A picture is worth of thousand words (credits to @Petar.petkovic)

I guess the fact that this happens makes sense in a way because it is a toolbar after all, but obviously it shouldn't happen.

Details

	Subject	Repo	Branch	Lines +/-
	Disable catchall for MT tools	mediawiki/extensions/ContentTranslation	master	+2 -0

Customize query in gerrit

Event Timeline

Nikerabbit created this task.Jun 7 2018, 3:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2018, 3:29 PM

Nikerabbit updated the task description. (Show Details)Jun 7 2018, 3:31 PM

Pginer-WMF triaged this task as Medium priority.Jun 11 2018, 12:15 PM

Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.

Pginer-WMF added a project: Language-2018-Apr-June.

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Apr-June board.Jun 12 2018, 6:46 AM

Keep in mind "Reset translation" appears in VE toolbar as well, not only inside modal dialogs.

ve-menu-item-in-more-tools.png (534×382 px, 16 KB)

Change 440993 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Disable catchall for MT tools

https://gerrit.wikimedia.org/r/440993

gerritbot added a project: Patch-For-Review.Jun 19 2018, 7:38 AM

• Petar.petkovic assigned this task to Nikerabbit.Jun 19 2018, 7:38 AM

• Petar.petkovic moved this task from Priority backlog to In Review on the Language-2018-Apr-June board.

Change 440993 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Disable catchall for MT tools

https://gerrit.wikimedia.org/r/440993

• Petar.petkovic removed a project: Patch-For-Review.Jun 19 2018, 8:19 AM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-Apr-June board.

Checked the fix in cx2-testing:

Screen Shot 2018-06-25 at 4.36.57 PM.png (556×548 px, 44 KB)

Screen Shot 2018-06-25 at 4.44.40 PM.png (562×1 px, 75 KB)

Nikerabbit moved this task from QA to Done on the Language-2018-Apr-June board.Jun 26 2018, 5:54 AM

• Petar.petkovic removed a subscriber: gerritbot.Jun 26 2018, 6:54 AM

• Petar.petkovic unsubscribed.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 1:01 PM

• Vvjjkkii renamed this task from CX2: Machine translation tools should not appear in toolbars inside modal dialogs to ygbaaaaaaa.Jul 1 2018, 1:05 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Nikerabbit as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from ygbaaaaaaa to CX2: Machine translation tools should not appear in toolbars inside modal dialogs.Jul 2 2018, 1:31 PM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Nikerabbit.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: • Petar.petkovic.

CommunityTechBot edited subscribers, added: Aklapper; removed: • Petar.petkovic.

	F22655636: Screen Shot 2018-06-25 at 4.44.40 PM.png
	Jun 26 2018, 12:02 AM

	F22655619: Screen Shot 2018-06-25 at 4.36.57 PM.png
	Jun 26 2018, 12:02 AM

	F22369477: ve-menu-item-in-more-tools.png
	Jun 19 2018, 7:33 AM

CX2: Machine translation tools should not appear in toolbars inside modal dialogsClosed, ResolvedPublicActions

Description

Details

Event Timeline

CX2: Machine translation tools should not appear in toolbars inside modal dialogs
Closed, ResolvedPublic
Actions