Page MenuHomePhabricator
Create Task
Maniphest T196672

ExtensionRegistry doesn't load extensions if they have an mtime of 0
Closed, ResolvedPublic
Actions

Description

Via patch from EdSchouten:

When creating Docker images of MediaWiki using the Bazel build system, I noticed that I'm not able to load any extensions. This is due to the fact that Bazel always generates container layers with mtimes of files set to 1970-01-01 for determinism/reproducibility.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
registration: Allow the mtime of extension.json files to be zeromediawiki/coreREL1_30+3 -1
registration: Allow the mtime of extension.json files to be zeromediawiki/coreREL1_27+3 -1
registration: Allow the mtime of extension.json files to be zeromediawiki/coreREL1_29+3 -1
registration: Allow the mtime of extension.json files to be zeromediawiki/coremaster+1 -1
registration: Allow the mtime of extension.json files to be zeromediawiki/coreREL1_31+1 -1
Customize query in gerrit

Event Timeline

Legoktm created this task.Jun 7 2018, 5:57 PM
Legoktm triaged this task as High priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2018, 5:57 PM
gerritbot subscribed.Jun 7 2018, 5:59 PM

Change 437977 had a related patch set uploaded (by Legoktm; owner: EdSchouten):
[mediawiki/core@master] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/437977

gerritbot added a project: Patch-For-Review.Jun 7 2018, 5:59 PM
gerritbot added a comment.Jun 7 2018, 6:10 PM

Change 437977 merged by jenkins-bot:
[mediawiki/core@master] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/437977

gerritbot added a comment.Jun 7 2018, 6:12 PM

Change 438066 had a related patch set uploaded (by Legoktm; owner: EdSchouten):
[mediawiki/core@REL1_31] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/438066

gerritbot added a comment.Jun 7 2018, 6:14 PM

Change 438067 had a related patch set uploaded (by Legoktm; owner: EdSchouten):
[mediawiki/core@REL1_30] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/438067

gerritbot added a comment.Jun 7 2018, 6:14 PM

Change 438068 had a related patch set uploaded (by Legoktm; owner: EdSchouten):
[mediawiki/core@REL1_29] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/438068

gerritbot added a comment.Jun 7 2018, 6:15 PM

Change 438069 had a related patch set uploaded (by Legoktm; owner: EdSchouten):
[mediawiki/core@REL1_27] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/438069

gerritbot added a comment.Jun 7 2018, 6:23 PM

Change 438066 merged by jenkins-bot:
[mediawiki/core@REL1_31] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/438066

ReleaseTaggerBot added projects: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), MW-1.31-release-notes.Jun 7 2018, 7:00 PM
gerritbot added a comment.Jun 8 2018, 9:21 PM

Change 438069 merged by jenkins-bot:
[mediawiki/core@REL1_27] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/438069

gerritbot added a comment.Jun 8 2018, 9:22 PM

Change 438068 merged by jenkins-bot:
[mediawiki/core@REL1_29] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/438068

gerritbot added a comment.Jun 8 2018, 9:28 PM

Change 438067 merged by jenkins-bot:
[mediawiki/core@REL1_30] registration: Allow the mtime of extension.json files to be zero

https://gerrit.wikimedia.org/r/438067

ReleaseTaggerBot added projects: MW-1.30-release-notes, MW-1.27-release-notes, MW-1.29-release-notes.Jun 8 2018, 10:00 PM
Krinkle closed this task as Resolved.Jun 10 2018, 1:08 AM
Krinkle moved this task from Backlog to Done on the MW-1.30-release board.
Krinkle moved this task from Backlog to Done on the MW-1.29-release board.
Krinkle moved this task from Backlog to Done on the MW-1.27-release board.
Krinkle removed a project: Patch-For-Review.
• Vvjjkkii renamed this task from ExtensionRegistry doesn't load extensions if they have an mtime of 0 to 7fbaaaaaaa.Jul 1 2018, 1:05 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 7fbaaaaaaa to ExtensionRegistry doesn't load extensions if they have an mtime of 0.Jul 2 2018, 8:45 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot claimed this task.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits