Page MenuHomePhabricator

Drag-dropping or copy-pasting an external link from one VE-MW surface onto another one loses the link
Open, LowPublic8 Story Points

Description

To reproduce:

  • In one browser window, an article with an external link
  • In another browser window, open a page in VE-MW
  • Select the link and drag-drop it onto the VE surface

Result:

  • The external link is lost

Recording: https://drive.google.com/file/d/1SLF9f4fToW9zgT6KDtHOGDZUL_rZ2_ln/view?usp=sharing (too large for Phab)

The same issue occurs with drag-drop between VE-MW surfaces, but it doesn't occur for copy-paste between VE-MW surfaces.

Edit: Updated description as stripping external link of import from plain CE is desired behaviour - Ed

Event Timeline

matmarex created this task.Jun 8 2018, 12:51 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 8 2018, 12:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex updated the task description. (Show Details)

(For context, I noticed this when reviewing https://gerrit.wikimedia.org/r/#/c/436611/.)

This is the same as paste, and is deliberate:

blacklist: [
			// Annotations
			'link/mwExternal', 'textStyle/span', 'textStyle/font', 'textStyle/underline', 'meta/language', 'textStyle/datetime',

although this rule is definitely designed with Wikipedia's in mind.

It is not the same as paste, because copy-pasting external links between VE-MW surfaces works. It's a problem with drag-drop from plain CE to VE-MW, and with copy-paste from plain CE or from VE-MW to VE-MW. The inconsistency is weird.

The example you give is from a plain CE surface, where the links are stripped whether you paste or drop.

To support VE->VE we'd need to set a custom key, like we do with copy.

Esanders triaged this task as Low priority.Jun 14 2018, 5:29 PM
Esanders renamed this task from Drag-dropping or copy-pasting an external link from contenteditable onto VE-MW surface loses the annotation to Drag-dropping or copy-pasting an external link from one VE-MW surface onto another one loses the link.Jun 14 2018, 5:32 PM
Esanders updated the task description. (Show Details)
Esanders set the point value for this task to 8.
Vvjjkkii renamed this task from Drag-dropping or copy-pasting an external link from one VE-MW surface onto another one loses the link to 0ebaaaaaaa.Jul 1 2018, 1:05 AM
Vvjjkkii raised the priority of this task from Low to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed the point value for this task.
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot set the point value for this task to 8.Jul 2 2018, 12:43 PM
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot lowered the priority of this task from High to Low.
CommunityTechBot renamed this task from 0ebaaaaaaa to Drag-dropping or copy-pasting an external link from one VE-MW surface onto another one loses the link.
CommunityTechBot added a subscriber: Aklapper.