Page MenuHomePhabricator
Create Task
Maniphest T196756

Consistently name document listeners
Closed, ResolvedPublic
Actions

Description

Should be named onDocumentEventName instead of just onEventName

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[BREAKING CHANGE] Consistently name document listenersoojs/uimaster+198 -97
Update OOUI to v0.29.1mediawiki/coremaster+484 -1 K
Update OOUI to v0.29.0mediawiki/coremaster+451 -1 K
Customize query in gerrit

Event Timeline

Esanders created this task.Jun 8 2018, 5:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2018, 5:33 PM
gerritbot subscribed.Jun 8 2018, 5:34 PM

Change 437960 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] [DEPRECATING CHANGE] Consistently name document listeners

https://gerrit.wikimedia.org/r/437960

gerritbot added a project: Patch-For-Review.Jun 8 2018, 5:34 PM
Volker_E moved this task from Backlog to Doing on the OOUI board.Jun 11 2018, 8:57 AM
• Vvjjkkii renamed this task from Consistently name document listeners to vdbaaaaaaa.Jul 1 2018, 1:05 AM
• Vvjjkkii removed Esanders as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from vdbaaaaaaa to Consistently name document listeners.Jul 2 2018, 3:07 PM
CommunityTechBot assigned this task to Esanders.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
gerritbot added a comment.Oct 1 2018, 11:49 PM

Change 437960 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] Consistently name document listeners

https://gerrit.wikimedia.org/r/437960

gerritbot added a comment.Oct 3 2018, 5:31 PM

Change 464370 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.29.0

https://gerrit.wikimedia.org/r/464370

Volker_E closed this task as Resolved.Oct 3 2018, 8:10 PM
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Doing to OOUI-0.29.0 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.29.0); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
gerritbot added a comment.Oct 4 2018, 5:13 PM

Change 464607 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607

gerritbot added a project: Patch-For-Review.Oct 4 2018, 5:13 PM

Change 464370 abandoned by Jforrester:
Update OOUI to v0.29.0

Reason:
Replaced by Ie847465af6762.

https://gerrit.wikimedia.org/r/464370

gerritbot added a comment.Oct 4 2018, 6:31 PM

Change 464607 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed Patch-For-Review.Oct 4 2018, 7:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits