Page MenuHomePhabricator
Create Task
Maniphest T196851

Evaluate BaseBot class usage across scripts
Open, MediumPublic
Actions

Description

Replace.py outputs how many pages were affected during its run, I find this information useful and want to add this output to other scripts as well.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Wesalius created this task.Jun 10 2018, 4:13 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 10 2018, 4:13 PM
Wesalius triaged this task as Low priority.Jun 10 2018, 4:14 PM
Framawiki added a subscriber: Framawiki.Jun 10 2018, 4:54 PM
Xqt added a subscriber: Xqt.Jun 10 2018, 7:50 PM

This is the default behavior of those scripts using BaseBot classes if not overwriting their run method.

Wesalius added a comment.Jun 10 2018, 8:40 PM

so the thing to do here is to check where and why the scripts overwrite the basebot run method?

Xqt added a comment.Jun 11 2018, 4:19 AM
In T196851#4270602, @Wesalius wrote:

so the thing to do here is to check where and why the scripts overwrite the basebot run method?

Yes. And which script does not use BaseBot classes.

Wesalius renamed this task from Add "no. of pages changed" output to pwb scripts to Evaluate BaseBot class usage across scripts.Jun 11 2018, 6:27 AM
Wesalius updated the task description. (Show Details)
Wesalius added a comment.Jun 11 2018, 6:47 PM
In T196851#4270839, @Xqt wrote:
In T196851#4270602, @Wesalius wrote:

so the thing to do here is to check where and why the scripts overwrite the basebot run method?

Yes. And which script does not use BaseBot classes.

@Xqt Can you please name an exemplary script that uses BaseBot so I can compare others?

Xqt added a comment.Jun 12 2018, 9:44 AM

All of them use either Bot, SingleSiteBot or MultipleSitesBot.

Wesalius removed Wesalius as the assignee of this task.Jun 23 2018, 11:52 AM

I am removing myself since it looks beyond my python knowledge. When creating the task I naively hoped to just add a simple counter to the script that missed the "x pages written output".

• Vvjjkkii renamed this task from Evaluate BaseBot class usage across scripts to 8abaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
Wesalius renamed this task from 8abaaaaaaa to Evaluate BaseBot class usage across scripts.Jul 1 2018, 10:34 AM
Wesalius lowered the priority of this task from High to Medium.
Wesalius removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Wesalius updated the task description. (Show Details)
Wesalius added a subscriber: Aklapper.
gerritbot added a subscriber: gerritbot.Jul 3 2018, 11:57 AM

Change 443590 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] use SingleSiteBot, AutomaticTWSummaryBot for CategoryListifyRobot

https://gerrit.wikimedia.org/r/443590

gerritbot added a project: Patch-For-Review.Jul 3 2018, 11:57 AM
Wesalius added a comment.Jul 4 2018, 5:21 AM

when listifying, the script outputs affected pages fine, when moving categories, there is no output

Xqt added a comment.Jul 4 2018, 1:08 PM
In T196851#4396737, @Wesalius wrote:

when listifying, the script outputs affected pages fine, when moving categories, there is no output

What output do you expect? Could you give an example.

gerritbot added a comment.Jul 4 2018, 1:42 PM

Change 443832 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] derive ImageTransferBot from SingleSiteBot

https://gerrit.wikimedia.org/r/443832

Wesalius added a comment.Jul 4 2018, 4:30 PM
In T196851#4397442, @Xqt wrote:
In T196851#4396737, @Wesalius wrote:

when listifying, the script outputs affected pages fine, when moving categories, there is no output

What output do you expect? Could you give an example.

Number of pages moved (analogy to number of pages written in other scripts)

Xqt claimed this task.Jul 16 2018, 6:44 AM
gerritbot added a comment.Jul 16 2018, 8:24 AM

Change 445955 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Derive SandboxBot from MultipleSitesBot and ExistingPageBot

https://gerrit.wikimedia.org/r/445955

Xqt mentioned this in T106121: RFC removing old code / code cleanup.Jul 17 2018, 10:56 AM
Dvorapa mentioned this in T203358: redirect.py does not count saved pages.Sep 2 2018, 6:30 PM
gerritbot added a comment.Sep 3 2018, 6:11 AM

Change 456999 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Adjust BaseBot._savecounter for RedirectRobot

https://gerrit.wikimedia.org/r/456999

gerritbot added a comment.Sep 5 2018, 8:19 PM

Change 456999 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Adjust BaseBot._savecounter for RedirectRobot

https://gerrit.wikimedia.org/r/456999

xSavitar moved this task from Backlog to Needs Review on the Pywikibot board.Nov 5 2018, 11:26 AM
Xqt added a subtask: T132135: template.py does not show when a page is saved.Nov 24 2018, 1:32 PM
Xqt added a subtask: T205205: Replace.py should handle OtherPageSaveError.Nov 24 2018, 1:37 PM
gerritbot added a comment.Apr 18 2020, 11:03 AM

Change 589717 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] rename replace.run() with replace.treat()

https://gerrit.wikimedia.org/r/589717

gerritbot added a comment.Apr 18 2020, 4:19 PM

Change 589872 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Remove duplicate counter in replace.py

https://gerrit.wikimedia.org/r/589872

gerritbot added a comment.Apr 18 2020, 7:07 PM

Change 589717 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] rename replace.run() with replace.treat()

https://gerrit.wikimedia.org/r/589717

Xqt mentioned this in rPWBC33a8d562fda3: [IMPR] rename replace.run() with replace.treat().Apr 18 2020, 8:35 PM
Xqt closed subtask T205205: Replace.py should handle OtherPageSaveError as Resolved.Apr 19 2020, 12:32 PM
gerritbot added a comment.Apr 20 2020, 8:32 AM

Change 589872 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Remove duplicate counter in replace.py

https://gerrit.wikimedia.org/r/589872

Xqt mentioned this in rPWBC96bc86439a3a: [bugfix] Remove duplicate counter in replace.py.Apr 20 2020, 8:37 AM
Xqt mentioned this in T258142: pwb outdated in PAWS.Jul 17 2020, 1:53 PM
gerritbot added a comment.Oct 30 2020, 6:04 AM

Change 636460 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Rename ReferencesRobot.run to treat

https://gerrit.wikimedia.org/r/636460

gerritbot added a comment.Oct 30 2020, 6:06 AM

Change 636132 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] split WelcomeBot.run into parts

https://gerrit.wikimedia.org/r/636132

gerritbot added a comment.Oct 30 2020, 11:09 AM

Change 636460 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Rename ReferencesRobot.run to treat

https://gerrit.wikimedia.org/r/636460

Xqt mentioned this in rPWBC3431d6d94f0a: [IMPR] Rename ReferencesRobot.run to treat.Oct 30 2020, 11:13 AM
gerritbot added a comment.Oct 30 2020, 12:38 PM

Change 443832 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] remove outdated "followRedirects" parameter from imagelinks()

https://gerrit.wikimedia.org/r/443832

gerritbot added a comment.Oct 30 2020, 1:03 PM

Change 443832 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] remove outdated "followRedirects" parameter from imagelinks()

https://gerrit.wikimedia.org/r/443832

Xqt mentioned this in rPWBC37161e8aad4d: [bugfix] remove outdated "followRedirects" parameter from imagelinks().Oct 30 2020, 1:06 PM
gerritbot added a comment.Nov 15 2020, 11:59 AM

Change 636132 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] split WelcomeBot.run into parts

https://gerrit.wikimedia.org/r/636132

Xqt mentioned this in rPWBC308b6c863856: [IMPR] split WelcomeBot.run into parts.Nov 15 2020, 12:03 PM
gerritbot added a comment.Nov 16 2020, 6:54 AM

Change 641057 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Derive CommonsLinkBot from CurrentPageBot

https://gerrit.wikimedia.org/r/641057

gerritbot added a comment.Feb 21 2021, 11:22 AM

Change 641057 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Derive CommonsLinkBot from CurrentPageBot

Reason:
no longer maintained

https://gerrit.wikimedia.org/r/641057

Xqt added a subtask: T276345: implement treat method in category_redirect.py.Mar 3 2021, 4:05 PM
Xqt added a subtask: T276348: implement treat method in clean_sandbox.py.
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 2 2021, 9:38 AM
Xqt closed subtask T132135: template.py does not show when a page is saved as Resolved.May 15 2021, 7:51 AM
Xqt mentioned this in T284388: Move add_text functionality to textlib.Jun 7 2021, 5:38 AM
gerritbot added a comment.Jun 11 2021, 1:26 PM

Change 699413 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [IMPR] Use CurrentPageBot for add_text script

https://gerrit.wikimedia.org/r/699413

gerritbot added a project: Patch-For-Review.Jun 11 2021, 1:26 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptJun 11 2021, 1:26 PM
gerritbot added a comment.Jun 12 2021, 1:33 PM

Change 699413 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] Use CurrentPageBot for add_text script

https://gerrit.wikimedia.org/r/699413

gerritbot added a comment.Sep 27 2021, 2:47 PM

Change 724000 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [IMPR] Derive blockpageschecker.py from CurrentPageBot

https://gerrit.wikimedia.org/r/724000

gerritbot added a comment.Sep 28 2021, 7:33 AM

Change 724000 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] Derive blockpageschecker.py from CurrentPageBot

https://gerrit.wikimedia.org/r/724000

Xqt removed Xqt as the assignee of this task.Apr 25 2022, 8:10 AM
Xqt removed a project: Patch-For-Review.
gerritbot added a comment.May 12 2022, 8:31 AM

Change 791307 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [IMPR] Use AutomaticTWSummaryBot to implement listpages

https://gerrit.wikimedia.org/r/791307

gerritbot added a project: Patch-For-Review.May 12 2022, 8:31 AM
gerritbot added a comment.May 21 2022, 9:19 AM

Change 791307 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] Use AutomaticTWSummaryBot to implement listpages

https://gerrit.wikimedia.org/r/791307

Xqt added a parent task: T171713: Make QuitKeyboardInterrupt errors unified and disable traceback in scripts.May 29 2022, 11:46 AM
Xqt added a subtask: T309456: implement treat method in nowcommons.py.May 29 2022, 11:49 AM
Xqt closed subtask T309456: implement treat method in nowcommons.py as Resolved.May 30 2022, 6:25 AM
Xqt removed a project: Patch-For-Review.Sep 9 2022, 7:26 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL