Maniphest T196876

tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dalba
	Jun 11 2018, 9:45 AM

Project Tags

Referenced Files

None

Subscribers

Description

The current returned error (if the allowed_failure decorator is removed):

$ python -m unittest tests.site_tests.TestPagePreloading.test_preload_langlinks_count
tests: max_retries reduced from 15 to 1
Retrieving 5 pages from wikipedia:en.
WARNING: ...\pywikibot-core\pywikibot\page.py:5878: UserWarning: Site wikipedia:be-tarask instantiated using
different code "be-x-old"
  link._site = pywikibot.Site(lang, source.family.name)

Retrieving 5 pages from wikipedia:en.
Retrieving 5 pages from wikipedia:en.
Retrieving 5 pages from wikipedia:en.
 28.752s F
======================================================================
FAIL: test_preload_langlinks_count (tests.site_tests.TestPagePreloading)
Test preloading continuation works.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "...\pywikibot-core\tests\site_tests.py", line 3081, in test_preload_langlinks_count
    self.assertEqual(len(list(links)), count)
AssertionError: 20 != 25

----------------------------------------------------------------------
Ran 1 test in 36.351s

FAILED (failures=1)

Also see https://travis-ci.org/wikimedia/pywikibot/jobs/390455476#L3168.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix handling of API continuation in PropertyGenerator	Dalba	pywikibot/core	master	+83 -36

Customize query in gerrit

Related Objects

Mentioned In: T205155: unconnected_pages generator doesn't seem to return all pages

Event Timeline

Dalba created this task.Jun 11 2018, 9:45 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 11 2018, 9:45 AM

Dalba added a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Jun 11 2018, 9:47 AM

Change 439643 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] Fix handling of API continuation in PropertyGenerator

https://gerrit.wikimedia.org/r/439643

gerritbot added a project: Patch-For-Review.Jun 11 2018, 6:20 PM

Dalba triaged this task as High priority.Jun 11 2018, 6:30 PM

Change 439643 merged by jenkins-bot:
[pywikibot/core@master] Fix handling of API continuation in PropertyGenerator

https://gerrit.wikimedia.org/r/439643

Xqt closed this task as Resolved.Jun 12 2018, 9:39 AM

• Vvjjkkii renamed this task from tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed to jabaaaaaaa.Jul 1 2018, 1:05 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Dalba as the assignee of this task.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from jabaaaaaaa to tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed.Jul 2 2018, 8:27 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Dalba.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

Dalba mentioned this in T205155: unconnected_pages generator doesn't seem to return all pages.Sep 23 2018, 2:18 PM

Xqt removed a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Jul 1 2024, 11:14 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2024, 11:32 AM

tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed
Closed, ResolvedPublic
Actions