Page MenuHomePhabricator
Create Task
Maniphest T196895

PolyGerrit doesn't support old UI URLs
Closed, ResolvedPublic
Actions

Description

Screenshot from 2018-06-11 07-47-14.png (896×938 px, 220 KB)
Screenshot from 2018-06-11 07-47-11.png (896×938 px, 53 KB)

The new UI seems to escape URLs differently than the old. E.g., consider the following query: (project:mediawiki/skins/MinervaNeue+OR+project:mediawiki/extensions/MobileFrontend). The URL in the old UI is this:

https://gerrit.wikimedia.org/r/#/q/(project:mediawiki/skins/MinervaNeue+OR+project:mediawiki/extensions/MobileFrontend)

The new UI shows a 404. I can, however, rebuild the query in the new UI and it generates this less friendly URL:

https://gerrit.wikimedia.org/r/q/(project:mediawiki%252Fskins%252FMinervaNeue+OR+project:mediawiki%252Fextensions%252FMobileFrontend)

The old UI works with the new URLs but the new UI doesn't work with the old URLs. It's probably not a big deal since I can just make new URLs but it's confusing. I thought these queries were completely unsupported until I tried to file this report. Also, the old URLs are so easy to construct by hand and read.

Another longer example:

https://gerrit.wikimedia.org/r/#/q/(project:marvin+OR+project:mediawiki/extensions/ElectronPdfService+OR+project:mediawiki/extensions/FeaturedFeeds+OR+project:mediawiki/extensions/MobileFrontend+OR+project:mediawiki/extensions/PageImages+OR+project:mediawiki/extensions/Popups+OR+project:mediawiki/extensions/QuickSurveys+OR+project:mediawiki/extensions/RelatedArticles+OR+project:mediawiki/extensions/RelatedSites+OR+project:mediawiki/extensions/TextExtracts+OR+project:mediawiki/extensions/VectorBeta+OR+project:mediawiki/extensions/WikidataPageBanner+OR+project:mediawiki/extensions/ZeroBanner+OR+project:mediawiki/services/trending-edits+OR+project:mediawiki/skins/MinervaNeue+OR+project:mediawiki/skins/Vector+OR+project:mediawiki/services/chromium-render+OR+project:mediawiki/services/chromium-render/deploy)+-age:1week+-author:l10n

And the new query:

https://gerrit.wikimedia.org/r/q/(project:marvin+OR+project:mediawiki%252Fextensions%252FElectronPdfService+OR+project:mediawiki%252Fextensions%252FFeaturedFeeds+OR+project:mediawiki%252Fextensions%252FMobileFrontend+OR+project:mediawiki%252Fextensions%252FPageImages+OR+project:mediawiki%252Fextensions%252FPopups+OR+project:mediawiki%252Fextensions%252FQuickSurveys+OR+project:mediawiki%252Fextensions%252FRelatedArticles+OR+project:mediawiki%252Fextensions%252FRelatedSites+OR+project:mediawiki%252Fextensions%252FTextExtracts+OR+project:mediawiki%252Fextensions%252FVectorBeta+OR+project:mediawiki%252Fextensions%252FWikidataPageBanner+OR+project:mediawiki%252Fextensions%252FZeroBanner+OR+project:mediawiki%252Fservices%252Ftrending-edits+OR+project:mediawiki%252Fskins%252FMinervaNeue+OR+project:mediawiki%252Fskins%252FVector+OR+project:mediawiki%252Fservices%252Fchromium-render+OR+project:mediawiki%252Fservices%252Fchromium-render%252Fdeploy)+-age:1week+-author:l10n

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT196895 PolyGerrit doesn't support old UI URLs
 ResolvedthciprianiT210785 Upgrade Gerrit to 2.15.8

Event Timeline

Niedzielski created this task.Jun 11 2018, 1:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2018, 1:04 PM
Paladox added a subscriber: Paladox.Jun 11 2018, 1:08 PM

Forwarded this upstream https://bugs.chromium.org/p/gerrit/issues/detail?id=9231

Seems this issue was fixed on the master branch some how.

Niedzielski added a comment.Jun 11 2018, 1:12 PM

Thanks @Paladox!

Aklapper added a project: Upstream.Jun 11 2018, 1:35 PM
• Vvjjkkii renamed this task from PolyGerrit doesn't support old UI URLs to 09aaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 09aaaaaaaa to PolyGerrit doesn't support old UI URLs.Jul 2 2018, 2:54 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Paladox added a subtask: T200739: Upgrade to Gerrit 2.16.13.Jul 31 2018, 12:02 AM
Dzahn added a subscriber: Dzahn.Sep 17 2018, 9:38 PM

I noticed this issue today when i wanted to share Gerrit links in a meeting and for multiple other users they were 404.

I wanted to report it as something that might require Apache rewrites before we can make Polygerrit default, then learned that this ticket already exists :) Thanks @Paladox

Paladox added a comment.Sep 17 2018, 9:41 PM

Note that this issue is fixed upstream but due to a big refactor in gr-router (which is how it maps the urls) it will require a new commit.

But i believe upstream are discussing to branch 2.16 now and then release it at the re hackathon in november (but that is not coming from google employees who do the releasing)

Paladox added a comment.Nov 3 2018, 8:55 PM

Fixed in https://gerrit-review.googlesource.com/c/gerrit/+/202831

Paladox moved this task from Bugs & stuff to PolyGerrit on the Gerrit board.Nov 4 2018, 11:59 PM
Paladox moved this task from Backlog to Patch merged upstream on the Upstream board.
Paladox moved this task from PolyGerrit to Maybe fixed? on the Gerrit board.Nov 9 2018, 5:54 PM
Paladox added a subtask: T210785: Upgrade Gerrit to 2.15.8.Nov 29 2018, 8:51 PM
Paladox removed a subtask: T200739: Upgrade to Gerrit 2.16.13.
Paladox closed this task as Resolved.Jan 16 2019, 7:42 PM
Paladox closed subtask T210785: Upgrade Gerrit to 2.15.8 as Resolved.

We have upgraded to 2.15.8 now. This should be fixed.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL