Maniphest T196914

Inspector not working correctly on double annotation
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Jun 11 2018, 3:41 PM

Description

Create a double annotation:

Notice that clicking in the middle of the text only shows one inspector:

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (8231b4d88)	mediawiki/extensions/VisualEditor	master	+1 -1
	Follow-up I125969a: Replace $.closest with $.parents + $.addBack	VisualEditor/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T197213: Have italics wrapping the label of a link makes it impossible to edit using VE
Mentioned Here: T197213: Have italics wrapping the label of a link makes it impossible to edit using VE
rGVED8231b4d8819c

Event Timeline

Esanders created this task.Jun 11 2018, 3:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2018, 3:41 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Jun 11 2018, 3:44 PM

Esanders updated the task description. (Show Details)

Esanders set the point value for this task to 1.

Change 439613 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Follow-up I125969a: Replace $.closest with $.parents + $.addBack

https://gerrit.wikimedia.org/r/439613

gerritbot added a project: Patch-For-Review.Jun 11 2018, 3:45 PM

Change 439613 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Follow-up I125969a: Replace $.closest with $.parents + $.addBack

https://gerrit.wikimedia.org/r/439613

Change 439624 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8231b4d88)

https://gerrit.wikimedia.org/r/439624

Change 439624 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8231b4d88)

https://gerrit.wikimedia.org/r/439624

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor-EditingTools; removed Patch-For-Review.Jun 11 2018, 5:35 PM

Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.

Ryasmeen added a project: Verified.Jun 13 2018, 3:26 AM

It still shows only one inspector when I put cursor at the very beginning or at the very end. Shouldn't it behave the same way for those positions?

Screen Shot 2018-06-12 at 8.35.52 PM.png (524×841 px, 87 KB)

Screen Shot 2018-06-12 at 8.35.31 PM.png (515×615 px, 42 KB)

matmarex mentioned this in T197213: Have italics wrapping the label of a link makes it impossible to edit using VE.Jun 14 2018, 4:44 PM

Per Dan on T197213, this is unbreak-now. We should probably backport the patch.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 14 2018, 11:00 PM

In T196914#4277758, @Ryasmeen wrote:

It still shows only one inspector when I put cursor at the very beginning or at the very end. Shouldn't it behave the same way for those positions?

I think this is the correct behavior. The link context should only display if we're displaying the active link styling (the light blue background and border). You might need to use keyboard arrow keys to navigate "inside" the link in such cases.

This is deployed everywhere already (since the train this morning).

• Deskana closed this task as Resolved.Jun 18 2018, 1:12 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 18 2018, 1:12 PM

Liuxinyu970226 unsubscribed.Jun 19 2018, 8:30 AM

• Vvjjkkii renamed this task from Inspector not working correctly on double annotation to h9aaaaaaaa.Jul 1 2018, 1:04 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Esanders as the assignee of this task.

• Vvjjkkii lowered the priority of this task from Unbreak Now! to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from h9aaaaaaaa to Inspector not working correctly on double annotation.Jul 2 2018, 12:37 PM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Esanders.

CommunityTechBot raised the priority of this task from High to Unbreak Now!.

CommunityTechBot set the point value for this task to 1.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

RandomDSdevel awarded a token.Oct 1 2018, 12:56 AM

	F22171584: Screen Shot 2018-06-12 at 8.35.52 PM.png
	Jun 13 2018, 3:37 AM

	F22171588: Screen Shot 2018-06-12 at 8.35.31 PM.png
	Jun 13 2018, 3:37 AM

Inspector not working correctly on double annotationClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Inspector not working correctly on double annotation
Closed, ResolvedPublic1 Estimated Story Points
Actions