Page MenuHomePhabricator
Create Task
Maniphest T196921

Three slugs in every header/footer on Wikisource VisualEditor, two of them don't work (cause an exception)
Closed, ResolvedPublic
Actions

Description

There are three slugs in every header or footer on Wikisource VisualEditor, and the latter two of them don't work (cause an exception when clicked).

For example: https://pl.wikisource.org/w/index.php?title=Strona:O_ontologicznej_beznadziejności_logiki,_fizykalizmu_i_pseudo-naukowego_monizmu_wogóle.djvu/7&veaction=edit

Uncaught TypeError: Cannot read property 'getModel' of undefined
    at Object.ve.ce.getOffsetOfSlug (load.php?debug=false&lang=pl&modules=ext.CodeMirror.lib|ext.visualEditor.core&skin=vector&version=1eaib6o:593)
    at VeCeSurface.ve.ce.Surface.createSlug (load.php?debug=false&lang=pl&modules=ext.CodeMirror.lib|ext.visualEditor.core&skin=vector&version=1eaib6o:712)
    at VeCeMwPagesSectionNode.ve.ce.BranchNode.onSlugClick (load.php?debug=false&lang=pl&modules=ext.CodeMirror.lib|ext.visualEditor.core&skin=vector&version=1eaib6o:624)
    at NoFocusButtonWidget.oo.EventEmitter.emit (<anonymous>:246:486)
    at NoFocusButtonWidget.OO.ui.mixin.ButtonElement.onClick (load.php?debug=false&lang=pl&modules=oojs-ui-core&skin=vector&version=1tuzbg3:25)
    at HTMLAnchorElement.dispatch (load.php?debug=false&lang=pl&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1j8y1b9:69)
    at HTMLAnchorElement.elemData.handle (load.php?debug=false&lang=pl&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1j8y1b9:66)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+1 -1Update VE core submodule to master (e72749663)
VisualEditor/VisualEditormaster+62 -32Ignore meta items when computing slug positions
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jun 11 2018, 4:10 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 11 2018, 4:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a comment.Jun 11 2018, 6:30 PM

It appears that there are three slugs because we try to insert them between every pair of nodes (except before the page quality selector, which is explicitly disallowed), and there are invisible meta nodes there (mwAlienMeta) corresponding to the <noinclude> and </noinclude> wikitext tags.

And they do not work before the meta nodes have no rendering (duh), and ve.ce.Surface.prototype.createSlug apparently only works if the slug is preceded by a node rendering.

This was probably caused by T56299 (before that, there was no meta nodes).

matmarex added a comment.Jun 11 2018, 6:34 PM

Actually, the real problem here is that the mwAlienMeta nodes are inside the sections, rather than outside. We do not want to allow inserting anything between the mwAlienMeta and beginning/end of section (since that content would end up outside <noinclude></noinclude> in wikitext).

Esanders added subscribers: dchan, Esanders.Jun 12 2018, 10:12 PM

Meta item really shouldn't trigger slugs. Pinging @dchan .

gerritbot added a subscriber: gerritbot.Jun 14 2018, 7:25 PM

Change 440391 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] Don't put slugs after meta items

https://gerrit.wikimedia.org/r/440391

gerritbot added a project: Patch-For-Review.Jun 14 2018, 7:25 PM
dchan added a comment.Jun 14 2018, 7:29 PM

@Esanders : yes, that seems to solve the issue, both in my local testing and when I monkey patch the live pl.wikisource.org page above.

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jun 14 2018, 10:35 PM
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jun 14 2018, 10:56 PM
gerritbot added a comment.Jun 19 2018, 9:23 AM

Change 440391 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Ignore meta items when computing slug positions

https://gerrit.wikimedia.org/r/440391

matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Jun 19 2018, 9:35 AM

Note for testing – similar issue also occurs in Wikipedia articles, with a block of non-functional slugs appearing at the end (they are inserted between the invisible category links).

gerritbot added a comment.Jun 20 2018, 10:31 AM

Change 441184 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e72749663)

https://gerrit.wikimedia.org/r/441184

gerritbot added a comment.Jun 20 2018, 3:28 PM

Change 441184 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e72749663)

https://gerrit.wikimedia.org/r/441184

Jdforrester-WMF assigned this task to matmarex.Jun 20 2018, 3:35 PM
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed Patch-For-Review.
Deskana closed this task as Resolved.Jun 25 2018, 2:48 PM
Deskana triaged this task as Low priority.
Ryasmeen added a project: Verified.Jun 30 2018, 1:12 AM
• Vvjjkkii renamed this task from Three slugs in every header/footer on Wikisource VisualEditor, two of them don't work (cause an exception) to a9aaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed matmarex as the assignee of this task.
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, archived--TCB-Team.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Bodhisattwa renamed this task from a9aaaaaaaa to Three slugs in every header/footer on Wikisource VisualEditor, two of them don't work (cause an exception).Jul 1 2018, 3:09 PM
Bodhisattwa closed this task as Resolved.
Bodhisattwa assigned this task to matmarex.
Bodhisattwa lowered the priority of this task from High to Low.
Bodhisattwa removed projects: archived--TCB-Team, Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Bodhisattwa updated the task description. (Show Details)
Bodhisattwa added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL