Page MenuHomePhabricator

Switchable wrapper in AbuseFilter's error message
Open, Needs TriagePublic

Description

Large projects have their own templates for reporting filter errors, moreover, there is a gradation of patterns, for example, in Russian Wikipedia, the templates for soft filters and hard filters are differently designed (https://ru.wikipedia.org/wiki/Википедия:Фильтр_правок#Сообщения, https://en.wikipedia.org/wiki/Wikipedia:Edit_filter).

Current outcome

When you try to save, all entire message MediaWiki:Abusefilter-*** is displayed in red wrapper based on Html::errorBox. Regardless of the type, at the moment we have a red text color and a box in the box.


In the same time if you are trying to edit a page which protected by filter, no wrappers will appear.

Expected outcome

  • First, we need to make the same display: when you try to edit and when you try to save.
  • Second, I think it will be useful to create the ability to customize this wrapper so that projects can design it as more convenient. As far as I understand, the wrapper functionality has been added for those who do not have such a number of templates. To save this, I think it is possible to add a page, for example MediaWiki:Abusefilter-wrapper, and you can change it to overwrite the wrapper. The second option is to create centrally individual messages that are dependent on the action: https://www.mediawiki.org/wiki/Extension:AbuseFilter/Actions.

Event Timeline

Strongly related to T187072, probably better to kill two birds with one stone

I don't think so. This is about allowing users to customize the style, the other is for making the text inside not become red. Probably it would be nice to solve everything at once, but the tasks aren't for the exact same thing.

Vvjjkkii renamed this task from Switchable wrapper in an error message to g8aaaaaaaa.Jul 1 2018, 1:04 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Daimona renamed this task from g8aaaaaaaa to Switchable wrapper in an error message.Jul 1 2018, 9:48 AM
Daimona raised the priority of this task from High to Needs Triage.
Daimona updated the task description. (Show Details)
Daimona added a project: AbuseFilter.
Daimona added a subscriber: Aklapper.

I added the UI-Standardization tag because of this extension needs to separate errors/prohibitions and warnings. Remove this tag if I'm wrong, please.

Iniquity renamed this task from Switchable wrapper in an error message to Switchable wrapper in AbuseFilter's error message .Jul 11 2019, 6:14 PM
Volker_E added a subscriber: Volker_E.

The color choice above fails strongly color contrast requirements for WCAG 2.0 level AA. I'd recommend orienting on Design Style Guide recommendations for error messages (also covered in T127405).

@Volker_E Well, that color choice should be modified in core, as that's the style for Html::errorBox. And yeah, it's awful, T187072.