Right now, we don't: see code. This could make the AbuseLog more readable, but this way it's not completely clear which actions contributed in the throttle count: suppose you have a filter which allows 2 edits before blocking the user. When the filter is executed, if it catches an edit with throttle count <= 2, there'll be no log, while the third match will be logged, and the reported action will be just "block". If this was the third edit by the user, this isn't a big deal. But what if the user made lots of edit and you want to know which ones contributed to throttle count? My proposal is to remove the "if" in the linked code portion, but I'd like to hear some other thoughts. Especially because I can't see why logging was disabled in this case, since logging in the AbuseLog should be the default action for every filter hit.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T209023 Major overhaul for AbuseFilter | |||
| Open | None | T203587 Major overhaul for "throttle" action in AbuseFilter | |||
| Open | None | T196995 Should we log filter hits for actions that were only throttled? |
Event Timeline
Comment Actions
Quick idea if we want to go on: we also need to change the code so that some things aren't executed if we were only throttling. For instance, the action shouldn't be counted for throttling the filter (=automatically disabling it).
Comment Actions
How is this related to this change? https://phabricator.wikimedia.org/rEABF24aef037852a991c40432b37d86953d26ea45a90
Comment Actions
That one was for "throttling" meaning "disable dangerous actions of a filter if it matches too many actions". No progress about "throttling" meant as "allow x action every y seconds".