Page MenuHomePhabricator

Should we log filter hits for actions that were only throttled?
Open, Needs TriagePublic

Description

Right now, we don't: see code. This could make the AbuseLog more readable, but this way it's not completely clear which actions contributed in the throttle count: suppose you have a filter which allows 2 edits before blocking the user. When the filter is executed, if it catches an edit with throttle count <= 2, there'll be no log, while the third match will be logged, and the reported action will be just "block". If this was the third edit by the user, this isn't a big deal. But what if the user made lots of edit and you want to know which ones contributed to throttle count? My proposal is to remove the "if" in the linked code portion, but I'd like to hear some other thoughts. Especially because I can't see why logging was disabled in this case, since logging in the AbuseLog should be the default action for every filter hit.

Event Timeline

Daimona created this task.Jun 12 2018, 1:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2018, 1:09 PM

Quick idea if we want to go on: we also need to change the code so that some things aren't executed if we were only throttling. For instance, the action shouldn't be counted for throttling the filter (=automatically disabling it).

Vvjjkkii renamed this task from Should we log filter hits for actions that were only throttled? to 86aaaaaaaa.Jul 1 2018, 1:04 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Daimona renamed this task from 86aaaaaaaa to Should we log filter hits for actions that were only throttled?.Jul 1 2018, 10:11 AM
Daimona raised the priority of this task from High to Needs Triage.
Daimona updated the task description. (Show Details)
Daimona added a subscriber: Aklapper.

That one was for "throttling" meaning "disable dangerous actions of a filter if it matches too many actions". No progress about "throttling" meant as "allow x action every y seconds".

Thanks. Those two things should be seriously disambiguated...

Those two things should be seriously disambiguated...

Definitely! I also get confused sometimes...

DannyS712 moved this task from Backlog to Logging on the AbuseFilter board.Thu, Oct 10, 6:29 AM