Page MenuHomePhabricator

Full-width maps cannot be properly edited in VisualEditor
Closed, DuplicatePublic

Description

Followup from T192251: Mapframes with a width of 100% fail to display on the mobile site unless "frameless" is used

First, we should encourage use of width="full" rather than width="100%" in map frame, since the code knows how to handle that better.

VisualEditor's scalable can't really handle full width very well, especially when resizing. This produces several big bugs here:

  1. When editing a page with a full-width map, the map appears, in VE, as "squished"
  2. If any edit happens on the full-width map with width="full" then the saved <mapframe> will get the width "NaN" instead

This should be fixed.

  • We should probably add an option in the VE dialog for a "full width" map (that hides the scaled numbers and provides "width=full".
  • As @Esanders recommended, we might want to prevent resizing (disable ve.ce.ResizableNode in a map node if the map is full width)

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 439964 had a related patch set uploaded (by Mooeypoo; owner: Esanders):
[mediawiki/extensions/Kartographer@master] Enable editing full-width maps in VE

https://gerrit.wikimedia.org/r/439964

Vvjjkkii renamed this task from Full-width maps cannot be properly edited in VisualEditor to s6aaaaaaaa.Jul 1 2018, 1:04 AM
Vvjjkkii removed Mooeypoo as the assignee of this task.
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from s6aaaaaaaa to Full-width maps cannot be properly edited in VisualEditor.Jul 2 2018, 2:04 PM
CommunityTechBot assigned this task to Mooeypoo.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: gerritbot, Aklapper.
Jhernandez edited projects, added Maps (Kartographer); removed Maps.

Change 439964 abandoned by Mooeypoo:
Enable editing full-width maps in VE

Reason:
Old, irrelevant by now.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Kartographer/ /439964