Maniphest T197029

Define in a single place the pseudoname of unnamed queries
Open, LowPublic
Actions

Assigned To

None

Authored By

	Framawiki
	Jun 12 2018, 7:09 PM

Description

Page title of unnamed queries is hardcoded in different template files.
Rather than redefining it several times, it should only be redefined in one place.
Perhaps in the model file ? At least in app.py only.

For example, one of them is :

{% if query.title %}{{query.title}}{% else %}Untitled query #{{ query.id }}{% endif %}

https://github.com/wikimedia/analytics-quarry-web/search?utf8=%E2%9C%93&q=Untitled+query&type=

https://github.com/wikimedia/analytics-quarry-web/blob/master/quarry/web/templates/query/view.html#L19
https://github.com/wikimedia/analytics-quarry-web/blob/master/quarry/web/templates/query/view.html#L54
https://github.com/wikimedia/analytics-quarry-web/blob/master/quarry/web/templates/user.html#L26
https://github.com/wikimedia/analytics-quarry-web/blob/master/quarry/web/templates/user.html#L39
https://github.com/wikimedia/analytics-quarry-web/blob/master/quarry/web/templates/user.html#L52

Event Timeline

Framawiki triaged this task as Low priority.Jun 12 2018, 7:09 PM

Framawiki created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2018, 7:09 PM

• Vvjjkkii renamed this task from Define in a single place the pseudoname of unnamed queries to a6aaaaaaaa.Jul 1 2018, 1:04 AM

• Vvjjkkii raised the priority of this task from Low to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from a6aaaaaaaa to Define in a single place the pseudoname of unnamed queries.Jul 2 2018, 9:35 AM

CommunityTechBot lowered the priority of this task from High to Low.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

How about a @property in the Query object?

rook added a project: good first task.May 20 2022, 12:10 PM

rook added a project: Wikimania-Hackathon-2022.Aug 3 2022, 4:05 PM

Aklapper moved this task from Inbox to Hacking Projects for Newcomers! on the Wikimania-Hackathon-2022 board.Aug 7 2022, 2:35 PM

rook removed a project: Wikimania-Hackathon-2022.Aug 18 2022, 2:52 PM

https://github.com/toolforge/quarry/pull/13

Define in a single place the pseudoname of unnamed queriesOpen, LowPublicActions

Description

Event Timeline

Define in a single place the pseudoname of unnamed queries
Open, LowPublic
Actions