Maniphest T197105

[Bug] Gallery next / previous buttons use default arrow instead of pointer (hand) cursor
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

Steps to Reproduce

Go to https://en.m.wikipedia.org/wiki/Barack_Obama#/media/File%3APresident_Barack_Obama.jpg
Move the mouse cursor over the advance or previous arrows

Expected Results

The hand cursor is shown to indicate that these are clickable links

Actual Results

The arrow cursor is shown

Environments Observed

enwiki

Browser Version

Chromium v66.0.3359.181

OS Version

Ubuntu v18.04 64b

Device Model

Desktop

Device Language

English

Developer notes

This should really be addressed in mw-ui-button.

Acceptance criteria

cursor: pointer applies for mw-ui-buttons

QA instructions

Environment: staging
Browser & device: desktop, all browsers
Skin: Minerva
Steps:

Go to https://reading-web-staging.wmflabs.org/wiki/Barack_Obama (or any other page with images)
Click on an image to open it in a modal
Mouse over the white previous or next arrows
Confirm that your cursor changes to the white click hand (instead of the default black arrow)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+8 -4	ImageOverlay arrows should be buttons

Customize query in gerrit

Related Objects

Mentioned In: T205321: [Bug] Search icon has no visual indication that it's a button on small screens
Mentioned Here: T145493: Some buttons in mobile interface don't indicate clickable target with pointer

Event Timeline

Niedzielski created this task.Jun 13 2018, 1:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2018, 1:15 PM

Niedzielski moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.Jun 13 2018, 1:19 PM

Jdlrobson moved this task from Backlog to Bugs on the MinervaNeue board.Jun 13 2018, 3:57 PM

This keeps coming up - see T145493.
@Volker_E can we just add cursor:pointer on all mw-ui-icon's or find some way to programmatically make sure they gain the cursor point? this seems to be the root cause of the problem here.

I'd rather not just fix one single case of this again but find a better long term solution.

• Vvjjkkii renamed this task from [Bug] Gallery next / previous buttons use pointer instead of hand cursor to 63aaaaaaaa.Jul 1 2018, 1:04 AM

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, archived--TCB-Team.

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 63aaaaaaaa to [Bug] Gallery next / previous buttons use pointer instead of hand cursor.Jul 2 2018, 12:29 PM

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot removed projects: archived--TCB-Team, Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot added a subscriber: Aklapper.

@Jdlrobson Sorry, that got lost in other stuff. A short term solution would be to apply cursor: pointer on .slider-button .mw-ui-icon or only on the arrow icons. But let's be honest, the markup is a crappy div soup. There's a title attribute on the slider buttons without content. Don't see patching on top of that as especially useful, but if you want to provide a patch for above, I'd merge it.

Agree that we should use cursor:pointer here. Taking it off the design board.

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 17 2018, 4:17 PM

In T197105#4382035, @Volker_E wrote:

@Jdlrobson Sorry, that got lost in other stuff. A short term solution would be to apply cursor: pointer on .slider-button .mw-ui-icon or only on the arrow icons. But let's be honest, the markup is a crappy div soup. There's a title attribute on the slider buttons without content. Don't see patching on top of that as especially useful, but if you want to provide a patch for above, I'd merge it.

Are there any downsides to applying to all mw-ui-button classes?

^ Renamed based on expected vs actual description. I think I mistitled this task before. Pointer is the current behavior and hand is the desired.

Jdlrobson mentioned this in T205321: [Bug] Search icon has no visual indication that it's a button on small screens.Sep 24 2018, 7:10 PM

Change 462560 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] ImageOverlay arrows should be buttons

https://gerrit.wikimedia.org/r/462560

gerritbot added a project: Patch-For-Review.Sep 24 2018, 7:12 PM

@Niedzielski The new title is still confusing as CSS uses value pointer for the hand cursor vs default for the arrow cursor.

Volker_E renamed this task from [Bug] Gallery next / previous buttons use hand instead of pointer cursor to [Bug] Gallery next / previous buttons use default arrow instead of pointer (hand) cursor.Sep 24 2018, 8:17 PM