Page MenuHomePhabricator

Exception while getting visual diff of template change
Closed, ResolvedPublic

Description

Specifically:

VM537:792 jQuery.Deferred exception: targetDomElements[i].hasAttribute is not a function TypeError: targetDomElements[i].hasAttribute is not a function
    at Object.ve.dm.Converter.static.renderHtmlAttributeList (https://wikitech.wikimedia.org/w/load.php?debug=false&lang=en&modules=ext.CodeMirror.lib%7Cext.visualEditor.core%7Coojs-ui-core&skin=vector&version=0xp73oq:484:513)
    at VeDmConverter.ve.dm.Converter.getDomElementsFromDataElement (https://wikitech.wikimedia.org/w/load.php?debug=false&lang=en&modules=ext.CodeMirror.lib%7Cext.visualEditor.core%7Coojs-ui-core&skin=vector&version=0xp73oq:489:198)
    at VeDmConverter.ve.dm.Converter.getDomSubtreeFromData (https://wikitech.wikimedia.org/w/load.php?debug=false&lang=en&modules=ext.CodeMirror.lib%7Cext.visualEditor.core%7Coojs-ui-core&skin=vector&version=0xp73oq:512:469)
    at VeDmConverter.ve.dm.Converter.getDomSubtreeFromModel (https://wikitech.wikimedia.org/w/load.php?debug=false&lang=en&modules=ext.CodeMirror.lib%7Cext.visualEditor.core%7Coojs-ui-core&skin=vector&version=0xp73oq:504:871)
    at VeDmConverter.ve.dm.Converter.getDomFromModel (https://wikitech.wikimedia.org/w/load.php?debug=false&lang=en&modules=ext.CodeMirror.lib%7Cext.visualEditor.core%7Coojs-ui-core&skin=vector&version=0xp73oq:503:955)
    at VeUiDiffElement.ve.ui.DiffElement.wrapNodeData (<anonymous>:419:71)
    at VeUiDiffElement.ve.ui.DiffElement.getChangedNodeElements (<anonymous>:419:979)
    at VeUiDiffElement.processQueue (<anonymous>:414:133)
    at VeUiDiffElement.ve.ui.DiffElement.renderDiff (<anonymous>:417:209)
    at new VeUiDiffElement (<anonymous>:410:683) undefined

Event Timeline

Change 440371 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Converter: Don't try to apply attributes to non-node elements

https://gerrit.wikimedia.org/r/440371

Change 440371 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Converter: Don't try to apply attributes to non-node elements

https://gerrit.wikimedia.org/r/440371

Change 440497 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (30865fcfe)

https://gerrit.wikimedia.org/r/440497

Change 440497 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (30865fcfe)

https://gerrit.wikimedia.org/r/440497

Deskana triaged this task as Medium priority.
Vvjjkkii renamed this task from Exception while getting visual diff of template change to y1aaaaaaaa.Jul 1 2018, 1:03 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Esanders as the assignee of this task.
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii edited subscribers, added: Esanders; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from y1aaaaaaaa to Exception while getting visual diff of template change.Jul 2 2018, 12:19 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Esanders.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: Esanders.