Maniphest T197218

Bots need to be adapted to new BaseBot abstraction
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Jun 14 2018, 8:53 AM

Description

The new code includes assertion that all items returned by the generator (and filtered by the method) are Page's. However, Pywikibot's Wikidata objects are subclasses of WikibasePage (and consequently BasePage which is a superclass of Page). This makes use of various Wikidata-related pagegenerators impossible (unless you override BaseBot's methods).

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] assert for BasePage instead of Page in BaseBot.run	pywikibot/core	master	+4 -4

Customize query in gerrit

Event Timeline

matej_suchanek created this task.Jun 14 2018, 8:53 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 14 2018, 8:53 AM

Xqt claimed this task.Jun 14 2018, 12:01 PM

Xqt triaged this task as High priority.

Change 440336 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] assert for BasePage instead of Page in BaseBot.run

https://gerrit.wikimedia.org/r/440336

gerritbot added a project: Patch-For-Review.Jun 14 2018, 12:06 PM

Change 440336 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] assert for BasePage instead of Page in BaseBot.run

https://gerrit.wikimedia.org/r/440336

Xqt closed this task as Resolved.Jun 19 2018, 10:10 AM

• Vvjjkkii renamed this task from Bots need to be adapted to new BaseBot abstraction to 10aaaaaaaa.Jul 1 2018, 1:04 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Xqt as the assignee of this task.